D15470.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D15470.diff
View Options

	diff --git a/src/applications/differential/controller/DifferentialDiffViewController.php b/src/applications/differential/controller/DifferentialDiffViewController.php
	--- a/src/applications/differential/controller/DifferentialDiffViewController.php
	+++ b/src/applications/differential/controller/DifferentialDiffViewController.php
	@@ -126,27 +126,40 @@
	->setRenderingReferences($refs)
	->setStandaloneURI('/differential/changeset/')
	->setDiff($diff)
	+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
	->setTitle(pht('Diff %d', $diff->getID()))
	->setUser($request->getUser());

	+ $title = pht('Diff %d', $diff->getID());
	$crumbs = $this->buildApplicationCrumbs();
	- $crumbs->addTextCrumb(pht('Diff %d', $diff->getID()));
	+ $crumbs->addTextCrumb($title);
	+ $crumbs->setBorder(true);
	+
	+ $header = id(new PHUIHeaderView())
	+ ->setHeader($title);

	$prop_box = id(new PHUIObjectBoxView())
	->setHeader($property_head)
	+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
	->addPropertyList($property_view)
	->setForm($form);

	- return $this->buildApplicationPage(
	- array(
	- $crumbs,
	+ $view = id(new PHUITwoColumnView())
	+ ->setHeader($header)
	+ ->setMainColumn(array(
	+
	+ ))
	+ ->setFooter(array(
	$prop_box,
	$table_of_contents,
	$details,
	- ),
	- array(
	- 'title' => pht('Diff View'),
	));
	+
	+ $page = $this->newPage()
	+ ->setTitle(pht('Diff View'))
	+ ->setCrumbs($crumbs)
	+ ->appendChild($view);
	+ return $page;
	}

	private function loadSelectableRevisions(