Page MenuHomePhabricator

Split the GitHub import cursor into separate repository and issues event importers
ClosedPublic

Authored by epriestley on Mar 9 2016, 1:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 7:50 AM
Unknown Object (File)
Thu, Apr 25, 1:48 AM
Unknown Object (File)
Mon, Apr 8, 8:41 AM
Unknown Object (File)
Apr 3 2024, 12:58 PM
Unknown Object (File)
Mar 30 2024, 12:02 AM
Unknown Object (File)
Mar 29 2024, 3:10 PM
Unknown Object (File)
Mar 11 2024, 10:37 AM
Unknown Object (File)
Mar 10 2024, 4:27 AM
Subscribers
None

Details

Summary

Ref T10538. The primary GitHub event activity stream does not report minor events (labels, milestones, etc).

GitHub has a second, similar activity stream which does report these events (the "Issues Events API").

Use two separate cursors: one consumes the primary stream; the second consumes the events stream.

One possible issue with this is that we may write events in a different order than they occurred, so GitHub shows "comment, label, close" but we show "comment, close, label" or similar. This is probably OK because the secondary API doesn't seem to have any very important events (e.g., it's probably fine if label changes are out-of-order), but we can conceivably put some buffer stage in between the two if it's an issue.

Test Plan

Screen Shot 2016-03-09 at 5.33.44 AM.png (1×1 px, 305 KB)

Diff Detail

Repository
rP Phabricator
Branch
nuance14
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11090
Build 13732: Run Core Tests
Build 13731: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Split the GitHub import cursor into separate repository and issues event importers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 9 2016, 3:20 PM
This revision was automatically updated to reflect the committed changes.