Allow things to figure out if `--trace` was passed
ClosedPublic
Actions

Authored by epriestley on Mar 7 2016, 12:00 AM.

Details

Reviewers

chad

Commits

rPHU62f63fc614a1: Allow things to figure out if `--trace` was passed

Summary

I want to make bin/phd debug only activate tracing if it was called with --trace, but there's no easy way to ask "is tracing enabled?" right now.

Provide such a method.

Test Plan

See next revision.

Diff Detail

Repository

rPHU libphutil

Branch

trace1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11039
Build 13651: Run Core Tests
Build 13650: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37177.Mar 7 2016, 12:00 AM

epriestley retitled this revision from to Allow things to figure out if `--trace` was passed.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley mentioned this in D15423: Make `bin/phd debug` quieter by default.Mar 7 2016, 12:02 AM

chad accepted this revision.Mar 7 2016, 4:34 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 7 2016, 4:34 AM

Closed by commit rPHU62f63fc614a1: Allow things to figure out if `--trace` was passed (authored by Evan Priestley <epriestley@Orbital.local>, committed by epriestley). · Explain WhyMar 7 2016, 1:28 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rP16a584ac7e3a: Make `bin/phd debug` quieter by default.Mar 7 2016, 4:04 PM

Revision Contents
Changeset List

Path

Size

src/

parser/

argument/

PhutilArgumentParser.php

7 lines

Diff 37177

View Options

src/parser/argument/PhutilArgumentParser.php

Allow things to figure out if `--trace` was passedClosedPublicActions