Ref T10093. Show better errors when a commit fails because it has already been merged and when a fetch fails because the ref isn't present in the remote.
Details
Details
- Reviewers
chad - Maniphest Tasks
- T10093: When builds fail because the staging area was not pushed, make the cause clear
- Commits
- Restricted Diffusion Commit
rP19eee427adb3: Improve Drydock errors for empty commits and missing changes
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- fetcherr
- Lint
Lint Passed Severity Location Code Message Advice src/applications/drydock/operation/DrydockLandRepositoryOperation.php:131 XHP16 TODO Comment - Unit
Tests Passed - Build Status
Buildable 11036 Build 13647: Run Core Tests Build 13646: arc lint + arc unit
Event Timeline
Comment Actions
we've been wondering for about a month now why on earth this would happen when no error output is produced
'git fetch %s && '. 'git checkout --force -B %s %s && '. 'git reset --hard %s && '. 'git clean -f -f -d -x',
amazing
Comment Actions
So that was our "foolproof" method of totally nuking and resetting the contents of a workspace before leasing it out again, and ironically, it does work all of the time, unless there is nothing to change about it.