Clean up Herald CSS
ClosedPublic
Actions

Authored by chad on Mar 6 2016, 9:05 PM.

Tags

None

Referenced Files

	F15480239: D15419.id37172.diff
	Tue, Apr 8, 12:52 PM

	F15475204: D15419.id37172.diff
	Sun, Apr 6, 5:29 PM

	F15468026: D15419.id.diff
	Thu, Apr 3, 7:28 PM

	F15467742: D15419.id37170.diff
	Thu, Apr 3, 5:37 PM

	F15464165: D15419.diff
	Wed, Apr 2, 6:57 AM

	F15464079: D15419.diff
	Wed, Apr 2, 6:17 AM

	F15447656: D15419.id.diff
	Fri, Mar 28, 12:50 AM

	F15447655: D15419.id37172.diff
	Fri, Mar 28, 12:50 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP8175f524e685: Clean up Herald CSS

Summary

I didn't test these very well and they looked silly when multiple rules applied.

Test Plan

Test various cases more, with single and multiple triggers.

Diff Detail

Repository

rP Phabricator

Branch

herald-css (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11032
Build 13641: Run Core Tests
Build 13640: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 37170.Mar 6 2016, 9:05 PM

chad retitled this revision from to Clean up Herald CSS.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptMar 6 2016, 9:05 PM

epriestley accepted this revision.Mar 6 2016, 9:33 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 6 2016, 9:33 PM

Closed by commit rP8175f524e685: Clean up Herald CSS (authored by chad, committed by chad). · Explain WhyMar 6 2016, 9:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

4 lines

webroot/

rsrc/

css/

application/

herald/

herald.css

4 lines

Diff 37170

View Options

resources/celerity/map.php