Clean up Herald CSS
ClosedPublic
Actions

Authored by chad on Mar 6 2016, 9:05 PM.

Tags

None

Referenced Files

	F19094503: D15419.diff
	Dec 4 2025, 1:02 AM

	F18797473: D15419.id37170.diff
	Oct 17 2025, 5:05 AM

	F18780588: D15419.diff
	Oct 12 2025, 5:40 PM

	F18397352: D15419.id.diff
	Aug 29 2025, 1:25 PM

	F18396668: D15419.id.diff
	Aug 29 2025, 12:38 PM

	F18396476: D15419.id37170.diff
	Aug 29 2025, 12:19 PM

	F18396359: D15419.diff
	Aug 29 2025, 12:11 PM

	F18396349: D15419.id37170.diff
	Aug 29 2025, 12:10 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP8175f524e685: Clean up Herald CSS

Summary

I didn't test these very well and they looked silly when multiple rules applied.

Test Plan

Test various cases more, with single and multiple triggers.

Diff Detail

Repository

rP Phabricator

Branch

herald-css (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11032
Build 13641: Run Core Tests
Build 13640: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 37170.Mar 6 2016, 9:05 PM

chad retitled this revision from to Clean up Herald CSS.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptMar 6 2016, 9:05 PM

epriestley accepted this revision.Mar 6 2016, 9:33 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 6 2016, 9:33 PM

Closed by commit rP8175f524e685: Clean up Herald CSS (authored by chad, committed by chad). · Explain WhyMar 6 2016, 9:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

4 lines

webroot/

rsrc/

css/

application/

herald/

herald.css

4 lines

Diff 37170

View Options

resources/celerity/map.php