Page MenuHomePhabricator
Differential D15416

Convert every two-column application except Maniphest to curtain views
ClosedPublic
Actions

Authored by epriestley on Mar 6 2016, 6:10 PM.
Tags
None
Referenced Files
F13222228: D15416.diff
Sun, May 19, 3:26 AM
F13204773: D15416.diff
Wed, May 15, 12:55 AM
F13192070: D15416.id37164.diff
Sun, May 12, 4:49 AM
F13188051: D15416.diff
Sat, May 11, 4:58 AM
Unknown Object (File)
Tue, May 7, 8:07 AM
Unknown Object (File)
Fri, May 3, 7:48 AM
Unknown Object (File)
Thu, Apr 25, 2:09 AM
Unknown Object (File)
Tue, Apr 23, 5:13 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rPfd9de5d6ecc8: Convert every two-column application except Maniphest to curtain views
Summary

Moves over everything except Maniphest, which has some special behavior.

Test Plan
  • Viewed a badge.
  • Viewed a calendar event.
  • Viewed a countdown.
  • Viewed a Fund initiative.
  • Viewed a Herald rule.
  • Viewed a macro.
  • Viewed an application.
  • Viewed an owners package.
  • Viewed a credential.
  • Viewed a Ponder question.
  • Viewed a poll.

Diff Detail

Repository
rP Phabricator
Branch
2col5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11026
Build 13632: Run Core Tests
Build 13631: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37164.Mar 6 2016, 6:10 PM
epriestley retitled this revision from to Convert every two-column application except Maniphest to curtain views.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Mar 6 2016, 6:41 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 6 2016, 6:41 PM
Closed by commit rPfd9de5d6ecc8: Convert every two-column application except Maniphest to curtain views (authored by epriestley, committed by epriestley). · Explain WhyMar 6 2016, 6:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
badges/
controller/
54 lines
base/
controller/
10 lines
calendar/
controller/
41 lines
countdown/
controller/
40 lines
fund/
controller/
44 lines
herald/
controller/
49 lines
macro/
controller/
44 lines
meta/
controller/
50 lines
owners/
controller/
90 lines
passphrase/
controller/
51 lines
ponder/
controller/
43 lines
slowvote/
controller/
41 lines

Diff 37164

View Options

src/applications/badges/controller/PhabricatorBadgesViewController.php

Loading...
View Options

src/applications/base/controller/PhabricatorController.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Loading...
View Options

src/applications/countdown/controller/PhabricatorCountdownViewController.php

Loading...
View Options

src/applications/fund/controller/FundInitiativeViewController.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleViewController.php

Loading...
View Options

src/applications/macro/controller/PhabricatorMacroViewController.php

Loading...
View Options

src/applications/meta/controller/PhabricatorApplicationDetailViewController.php

Loading...
View Options

src/applications/owners/controller/PhabricatorOwnersDetailController.php

Loading...
View Options

src/applications/passphrase/controller/PassphraseCredentialViewController.php

Loading...
View Options

src/applications/ponder/controller/PonderQuestionViewController.php

Loading...
View Options

src/applications/slowvote/controller/PhabricatorSlowvotePollController.php

Loading...
Phabricator · Built by Phacility