Page MenuHomePhabricator
Differential D15406

Clean up Macro view page
ClosedPublic
Actions

Authored by chad on Mar 5 2016, 8:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 18, 10:29 PM
Unknown Object (File)
Sun, Apr 27, 3:20 PM
Unknown Object (File)
Apr 23 2025, 10:56 PM
Unknown Object (File)
Apr 12 2025, 11:26 AM
Unknown Object (File)
Apr 11 2025, 5:59 AM
Unknown Object (File)
Apr 11 2025, 4:51 AM
Unknown Object (File)
Apr 10 2025, 7:34 PM
Unknown Object (File)
Mar 28 2025, 1:06 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP090252a89e2b: Clean up Macro view page
Summary

Sets a header icon, makes "Details" not show if empty, simplifies title.

Test Plan

Review a few Macro pages for changes with and without audio.

Diff Detail

Repository
rP Phabricator
Branch
macro-three (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11004
Build 13599: Run Core Tests
Build 13598: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 37142.Mar 5 2016, 8:30 PM
chad retitled this revision from to Clean up Macro view page.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptMar 5 2016, 8:30 PM
epriestley accepted this revision.Mar 5 2016, 8:41 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 5 2016, 8:41 PM
Closed by commit rP090252a89e2b: Clean up Macro view page (authored by chad, committed by chad). · Explain WhyMar 5 2016, 8:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
macro/
controller/
9 lines

Diff 37142

View Options

src/applications/macro/controller/PhabricatorMacroViewController.php

Loading...
Phabricator · Built by Phacility