Clean up Macro view page
ClosedPublic
Actions

Authored by chad on Mar 5 2016, 8:30 PM.

Tags

None

Referenced Files

	F14833188: D15406.diff
	Thu, Jan 30, 9:04 AM

	F14831348: D15406.id37142.diff
	Thu, Jan 30, 1:13 AM

	Unknown Object (File)
	Mon, Jan 20, 2:41 PM

	Unknown Object (File)
	Dec 18 2024, 9:04 AM

	Unknown Object (File)
	Dec 11 2024, 9:22 AM

	Unknown Object (File)
	Dec 10 2024, 7:11 PM

	Unknown Object (File)
	Dec 7 2024, 11:01 AM

	Unknown Object (File)
	Dec 3 2024, 4:13 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP090252a89e2b: Clean up Macro view page

Summary

Sets a header icon, makes "Details" not show if empty, simplifies title.

Test Plan

Review a few Macro pages for changes with and without audio.

Diff Detail

Repository

rP Phabricator

Branch

macro-three (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11004
Build 13599: Run Core Tests
Build 13598: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 37142.Mar 5 2016, 8:30 PM

chad retitled this revision from to Clean up Macro view page.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptMar 5 2016, 8:30 PM

epriestley accepted this revision.Mar 5 2016, 8:41 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 5 2016, 8:41 PM

Closed by commit rP090252a89e2b: Clean up Macro view page (authored by chad, committed by chad). · Explain WhyMar 5 2016, 8:42 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

macro/

controller/

PhabricatorMacroViewController.php

9 lines

Diff 37142

View Options

src/applications/macro/controller/PhabricatorMacroViewController.php

Clean up Macro view pageClosedPublicActions