Page MenuHomePhabricator
Differential D15399

Use EditEngine for AlmanacDevice
ClosedPublic
Actions

Authored by epriestley on Mar 5 2016, 12:26 AM.
Tags
None
Referenced Files
F15514594: D15399.diff
Fri, Apr 18, 3:50 AM
F15514091: D15399.id37126.diff
Fri, Apr 18, 12:21 AM
F15460131: D15399.diff
Mon, Mar 31, 8:23 PM
F15458643: D15399.id37126.diff
Mon, Mar 31, 5:53 AM
F15449421: D15399.id.diff
Fri, Mar 28, 10:07 AM
F15447144: D15399.diff
Thu, Mar 27, 10:06 PM
F15428584: D15399.id.diff
Sun, Mar 23, 9:15 PM
F15403001: D15399.id37130.diff
Mar 18 2025, 1:35 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10449: Almanac v2 (Unprototype)
Commits
Restricted Diffusion Commit
rP85bf04ea0292: Use EditEngine for AlmanacDevice
Summary

Ref T10449. Modernize the AlmanacDevice code a bit.

Test Plan
  • Created a device.
  • Edited a device.
  • Listed devices.
  • Viewed a device.

Diff Detail

Repository
rP Phabricator
Branch
dry25
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10985
Build 13572: Run Core Tests
Build 13571: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37126.Mar 5 2016, 12:26 AM
epriestley retitled this revision from to Use EditEngine for AlmanacDevice.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10449: Almanac v2 (Unprototype).
chad accepted this revision.Mar 5 2016, 1:11 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 5 2016, 1:11 AM
Closed by commit rP85bf04ea0292: Use EditEngine for AlmanacDevice (authored by epriestley, committed by epriestley). · Explain WhyMar 5 2016, 1:22 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 37126

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/almanac/application/PhabricatorAlmanacApplication.php

Loading...
View Options

src/applications/almanac/controller/AlmanacDeviceController.php

Loading...
View Options

src/applications/almanac/controller/AlmanacDeviceEditController.php

Loading...
View Options

src/applications/almanac/controller/AlmanacDeviceListController.php

Loading...
View Options

src/applications/almanac/editor/AlmanacDeviceEditEngine.php

Loading...
Phabricator · Built by Phacility