Page MenuHomePhabricator
Differential D15399

Use EditEngine for AlmanacDevice
ClosedPublic
Actions

Authored by epriestley on Mar 5 2016, 12:26 AM.
Tags
None
Referenced Files
F19082024: D15399.diff
Tue, Dec 2, 9:19 AM
F19060583: D15399.id37126.diff
Sat, Nov 29, 9:44 AM
F19053339: D15399.id.diff
Fri, Nov 28, 8:08 AM
F19050335: D15399.diff
Thu, Nov 27, 7:42 PM
F19041580: D15399.diff
Wed, Nov 26, 4:09 PM
F18841347: D15399.id.diff
Oct 28 2025, 8:21 AM
F18839947: D15399.diff
Oct 27 2025, 8:06 PM
F18830037: D15399.diff
Oct 25 2025, 3:28 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10449: Almanac v2 (Unprototype)
Commits
Restricted Diffusion Commit
rP85bf04ea0292: Use EditEngine for AlmanacDevice
Summary

Ref T10449. Modernize the AlmanacDevice code a bit.

Test Plan
  • Created a device.
  • Edited a device.
  • Listed devices.
  • Viewed a device.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37126.Mar 5 2016, 12:26 AM
epriestley retitled this revision from to Use EditEngine for AlmanacDevice.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10449: Almanac v2 (Unprototype).
chad accepted this revision.Mar 5 2016, 1:11 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 5 2016, 1:11 AM
Closed by commit rP85bf04ea0292: Use EditEngine for AlmanacDevice (authored by epriestley, committed by epriestley). · Explain WhyMar 5 2016, 1:22 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 37130

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/almanac/application/PhabricatorAlmanacApplication.php

Loading...
View Options

src/applications/almanac/controller/AlmanacDeviceController.php

Loading...
View Options

src/applications/almanac/controller/AlmanacDeviceEditController.php

Loading...
View Options

src/applications/almanac/controller/AlmanacDeviceListController.php

Loading...
View Options

src/applications/almanac/editor/AlmanacDeviceEditEngine.php

Loading...
Phabricator · Built by Phacility