Page MenuHomePhabricator
Differential D15373

Update Herald for PHUITwoColumnView
ClosedPublic
Actions

Authored by chad on Mar 1 2016, 6:16 PM.
Tags
None
Referenced Files
F15375615: D15373.id37070.diff
Wed, Mar 12, 11:35 PM
F15375614: D15373.id.diff
Wed, Mar 12, 11:35 PM
F15336291: D15373.id37070.diff
Sat, Mar 8, 6:39 PM
F15336290: D15373.id.diff
Sat, Mar 8, 6:39 PM
F15327832: D15373.diff
Fri, Mar 7, 5:05 AM
Unknown Object (File)
Mon, Mar 3, 12:38 PM
Unknown Object (File)
Sun, Feb 23, 3:58 AM
Unknown Object (File)
Mon, Feb 17, 7:55 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPdb4fdf8c2d07: Update Herald for PHUITwoColumnView
Summary

Updates Herald to new two column layout

Test Plan

View herald rule tablet, desktop, mobile

Diff Detail

Repository
rP Phabricator
Branch
herald-two (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10923
Build 13477: Run Core Tests
Build 13476: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 37066.Mar 1 2016, 6:16 PM
chad retitled this revision from to Update Herald for PHUITwoColumnView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptMar 1 2016, 6:16 PM
epriestley accepted this revision.Mar 1 2016, 7:35 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 1 2016, 7:35 PM
Closed by commit rPdb4fdf8c2d07: Update Herald for PHUITwoColumnView (authored by chad, committed by chad). · Explain WhyMar 1 2016, 8:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
herald/
controller/
42 lines

Diff 37066

View Options

src/applications/herald/controller/HeraldRuleViewController.php

Loading...
Phabricator · Built by Phacility