Update Herald for PHUITwoColumnView
ClosedPublic
Actions

Authored by chad on Mar 1 2016, 6:16 PM.

Tags

None

Referenced Files

	F17860418: D15373.diff
	Sun, Jul 27, 9:49 PM

	Unknown Object (File)
	May 27 2025, 10:54 AM

	Unknown Object (File)
	May 19 2025, 5:36 AM

	Unknown Object (File)
	May 10 2025, 8:40 AM

	Unknown Object (File)
	May 6 2025, 10:12 AM

	Unknown Object (File)
	Apr 24 2025, 8:30 PM

	Unknown Object (File)
	Apr 16 2025, 6:18 AM

	Unknown Object (File)
	Mar 31 2025, 11:30 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rPdb4fdf8c2d07: Update Herald for PHUITwoColumnView

Summary

Updates Herald to new two column layout

Test Plan

View herald rule tablet, desktop, mobile

Diff Detail

Repository

rP Phabricator

Branch

herald-two (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10923
Build 13477: Run Core Tests
Build 13476: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 37066.Mar 1 2016, 6:16 PM

chad retitled this revision from to Update Herald for PHUITwoColumnView.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptMar 1 2016, 6:16 PM

epriestley accepted this revision.Mar 1 2016, 7:35 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 1 2016, 7:35 PM

Closed by commit rPdb4fdf8c2d07: Update Herald for PHUITwoColumnView (authored by chad, committed by chad). · Explain WhyMar 1 2016, 8:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

controller/

HeraldRuleViewController.php

42 lines

Diff 37066

View Options

src/applications/herald/controller/HeraldRuleViewController.php

Update Herald for PHUITwoColumnViewClosedPublicActions