Page MenuHomePhabricator
Differential D15356

Update Buildable search in Harbormaster
ClosedPublic
Actions

Authored by epriestley on Feb 26 2016, 8:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 24, 1:07 PM
Unknown Object (File)
Sun, Sep 1, 2:30 PM
Unknown Object (File)
Sun, Sep 1, 2:30 PM
Unknown Object (File)
Sun, Sep 1, 2:30 PM
Unknown Object (File)
Sun, Sep 1, 2:30 PM
Unknown Object (File)
Sun, Sep 1, 1:57 AM
Unknown Object (File)
Aug 16 2024, 3:38 PM
Unknown Object (File)
Aug 13 2024, 6:13 PM
View All Files
Subscribers
Luke081515.2
Tokens
"Like" token, awarded by Luke081515.2."Love" token, awarded by michaeljs1990.

Details

Reviewers
chad
Maniphest Tasks
T10011: Allow to search for the build status in habormaster querys
Commits
Restricted Diffusion Commit
rPc29ba039bbda: Update Buildable search in Harbormaster
Summary

Fixes T10011.

  • Modernize searching for buildables.
  • Prepare for harbormaster.buildable.search.
  • Allow users to query by status (see T10011).
  • Collapse the four weird "commit / diff / revision / repository" fields into two slightly less weird fields with more UI hinting?
Test Plan

Screen Shot 2016-02-26 at 12.46.48 PM.png (686×753 px, 71 KB)

Diff Detail

Repository
rP Phabricator
Branch
dry5
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php:58XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 10865
Build 13397: Run Core Tests
Build 13396: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37028.Feb 26 2016, 8:47 PM
epriestley retitled this revision from to Update Buildable search in Harbormaster.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10011: Allow to search for the build status in habormaster querys.
chad accepted this revision.Feb 26 2016, 9:31 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 26 2016, 9:31 PM
michaeljs1990 awarded a token.Feb 26 2016, 10:03 PM
Luke081515.2 awarded a token.Feb 26 2016, 10:57 PM
Luke081515.2 added a subscriber: Luke081515.2.
Closed by commit rPc29ba039bbda: Update Buildable search in Harbormaster (authored by epriestley, committed by epriestley). · Explain WhyFeb 27 2016, 3:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
query/
13 lines
193 lines
storage/
20 lines
search/
field/
20 lines

Diff 37028

View Options

src/applications/harbormaster/query/HarbormasterBuildableQuery.php

Loading...
View Options

src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php

Loading...
View Options

src/applications/harbormaster/storage/HarbormasterBuildable.php

Loading...
View Options

src/applications/search/field/PhabricatorSearchStringListField.php

Loading...
Phabricator · Built by Phacility