Paths

Table of Contentst

Differential D15356

Update Buildable search in Harbormaster
ClosedPublic
Actions

Authored by epriestley on Feb 26 2016, 8:47 PM.

Tags

None

Referenced Files

	F14044461: D15356.id37028.diff
	Tue, Nov 12, 4:27 PM

	F14044455: D15356.id37032.diff
	Tue, Nov 12, 4:25 PM

	F14013773: D15356.id37028.diff
	Sat, Nov 2, 1:01 PM

	F14008270: D15356.id37032.diff
	Tue, Oct 29, 6:53 PM

	F14003526: D15356.id37028.diff
	Sat, Oct 26, 7:09 AM

	F14003519: D15356.id37032.diff
	Sat, Oct 26, 7:07 AM

	F14003256: D15356.id.diff
	Sat, Oct 26, 4:04 AM

	F14001116: D15356.id37028.diff
	Fri, Oct 25, 4:17 AM

Subscribers

Tokens

"Like" token, awarded by Luke081515.2."Love" token, awarded by michaeljs1990.

Details

Reviewers

Maniphest Tasks

T10011: Allow to search for the build status in habormaster querys

Commits

Restricted Diffusion Commit
rPc29ba039bbda: Update Buildable search in Harbormaster

Summary

Fixes T10011.

Modernize searching for buildables.
Prepare for harbormaster.buildable.search.
Allow users to query by status (see T10011).
Collapse the four weird "commit / diff / revision / repository" fields into two slightly less weird fields with more UI hinting?

Test Plan

Screen Shot 2016-02-26 at 12.46.48 PM.png (686×753 px, 71 KB)

Diff Detail

Repository

Branch

dry5

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php:58	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 10865
Build 13397: Run Core Tests
Build 13396: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37028.Feb 26 2016, 8:47 PM

epriestley retitled this revision from to Update Buildable search in Harbormaster.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10011: Allow to search for the build status in habormaster querys.

chad accepted this revision.Feb 26 2016, 9:31 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 26 2016, 9:31 PM

michaeljs1990 awarded a token.Feb 26 2016, 10:03 PM

Luke081515.2 awarded a token.Feb 26 2016, 10:57 PM

Luke081515.2 added a subscriber: Luke081515.2.

Closed by commit rPc29ba039bbda: Update Buildable search in Harbormaster (authored by epriestley, committed by epriestley). · Explain WhyFeb 27 2016, 3:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

query/

HarbormasterBuildableQuery.php

13 lines

HarbormasterBuildableSearchEngine.php

193 lines

storage/

HarbormasterBuildable.php

20 lines

search/

field/

PhabricatorSearchStringListField.php

20 lines

Diff 37028

src/applications/harbormaster/query/HarbormasterBuildableQuery.php

Loading...

src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php

Loading...

src/applications/harbormaster/storage/HarbormasterBuildable.php

Loading...

src/applications/search/field/PhabricatorSearchStringListField.php

Loading...