Page MenuHomePhabricator

Require "Can Edit" on a build plan to abort or pause associated builds
ClosedPublic

Authored by epriestley on Feb 26 2016, 7:32 PM.
Tags
None
Referenced Files
F13161086: D15353.diff
Mon, May 6, 4:56 AM
Unknown Object (File)
Fri, May 3, 10:17 AM
Unknown Object (File)
Thu, Apr 25, 3:45 AM
Unknown Object (File)
Fri, Apr 19, 4:15 PM
Unknown Object (File)
Mon, Apr 8, 1:34 AM
Unknown Object (File)
Apr 3 2024, 8:49 PM
Unknown Object (File)
Mar 21 2024, 12:19 PM
Unknown Object (File)
Mar 5 2024, 7:21 PM
Subscribers
None

Details

Summary

Fixes T9614. This is kind of silly, but stop users from fighting turf wars over build resources or showing up on an install and just aborting a bunch of builds for the heck of it.

Test Plan
  • Restarted / paused / aborted / etc builds.
  • Tried to do the same for builds I didn't have edit permission on the build plan for, got errors.

Diff Detail

Repository
rP Phabricator
Branch
dry2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10861
Build 13390: Run Core Tests
Build 13389: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Require "Can Edit" on a build plan to abort or pause associated builds.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 26 2016, 7:35 PM
This revision was automatically updated to reflect the committed changes.