Page MenuHomePhabricator
Differential D15353

Require "Can Edit" on a build plan to abort or pause associated builds
ClosedPublic
Actions

Authored by epriestley on Feb 26 2016, 7:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 31, 3:50 PM
Unknown Object (File)
Thu, Jan 30, 4:19 PM
Unknown Object (File)
Wed, Jan 29, 12:14 PM
Unknown Object (File)
Mon, Jan 27, 3:37 AM
Unknown Object (File)
Sat, Jan 25, 1:50 PM
Unknown Object (File)
Sat, Jan 25, 1:50 PM
Unknown Object (File)
Sat, Jan 25, 1:50 PM
Unknown Object (File)
Fri, Jan 24, 12:01 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds
Commits
Restricted Diffusion Commit
rP9d051cddd367: (stable) Promote 2016 Week 9
rP93b8f803a02b: Require "Can Edit" on a build plan to abort or pause associated builds
Summary

Fixes T9614. This is kind of silly, but stop users from fighting turf wars over build resources or showing up on an install and just aborting a bunch of builds for the heck of it.

Test Plan
  • Restarted / paused / aborted / etc builds.
  • Tried to do the same for builds I didn't have edit permission on the build plan for, got errors.

Diff Detail

Repository
rP Phabricator
Branch
dry2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10861
Build 13390: Run Core Tests
Build 13389: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37024.Feb 26 2016, 7:32 PM
epriestley retitled this revision from to Require "Can Edit" on a build plan to abort or pause associated builds.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds.
chad accepted this revision.Feb 26 2016, 7:35 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 26 2016, 7:35 PM
Closed by commit rP93b8f803a02b: Require "Can Edit" on a build plan to abort or pause associated builds (authored by epriestley, committed by epriestley). · Explain WhyFeb 26 2016, 7:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 37024

View Options

src/applications/harbormaster/controller/HarbormasterBuildActionController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildViewController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildableActionController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildableViewController.php

Loading...
View Options

src/applications/harbormaster/editor/HarbormasterBuildTransactionEditor.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuild.php

Loading...
Phabricator · Built by Phacility