Page MenuHomePhabricator

Require "Can Edit" on a build plan to abort or pause associated builds
ClosedPublic

Authored by epriestley on Feb 26 2016, 7:32 PM.
Tags
None
Referenced Files
F15565737: D15353.diff
Thu, May 1, 7:56 AM
F15485847: D15353.diff
Thu, Apr 10, 2:59 AM
F15460758: D15353.id.diff
Apr 1 2025, 1:57 AM
F15437227: D15353.id37025.diff
Mar 25 2025, 6:27 PM
F15433736: D15353.id37024.diff
Mar 25 2025, 12:27 AM
F15431102: D15353.id.diff
Mar 24 2025, 10:31 AM
F15426403: D15353.diff
Mar 23 2025, 8:30 AM
F15413560: D15353.diff
Mar 19 2025, 7:40 PM
Subscribers
None

Details

Summary

Fixes T9614. This is kind of silly, but stop users from fighting turf wars over build resources or showing up on an install and just aborting a bunch of builds for the heck of it.

Test Plan
  • Restarted / paused / aborted / etc builds.
  • Tried to do the same for builds I didn't have edit permission on the build plan for, got errors.

Diff Detail

Repository
rP Phabricator
Branch
dry2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10861
Build 13390: Run Core Tests
Build 13389: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Require "Can Edit" on a build plan to abort or pause associated builds.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 26 2016, 7:35 PM
This revision was automatically updated to reflect the committed changes.