Fixes T10431. Updates the getAliases() method to read every arc configuration file.
Details
Details
- Reviewers
chad nevogd - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T10431: Allow arc alias to read aliases from system configuration file
- Commits
- rARC7891df6f2584: Read arc aliases from all available configuration files
Added an arc duck alias to /etc/arcconfig, ran arc duck, saw "quack".
Added an arc pig alias to ~/.arcrc via arc alias, ran arc pig, saw "oink oink".
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- T10431_aliases
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 10838 Build 15857: Run Core Tests Build 13358: arc lint + arc unit
Event Timeline
Comment Actions
Historically, the initial version of "aliases" was intended to be user specific, so it wasn't a "config" key.
D2191 changed this so that .arcconfig could also define them, but they remained defined in a nonstandard way in .arcrc.
Later changes added more configuration sources and D7271 consolidated configuration management, but since this one was weird it never got expanded to work with other sources.
This makes "aliases" definable in any source using standard precedence rules (runtime, local, project, user, system) by working around the weirdness of the "aliases" key in the ConfigurationManager itself. This isn't especially pretty but makes the behavior correct.