Differential D15335

Only hide archived project tags on workboard cards
ClosedPublic
Actions

Authored by epriestley on Feb 23 2016, 6:45 PM.

Details

Reviewers

chad

Maniphest Tasks

T10413: Archived project tags are hidden everywhere, not just on Workboard cards

Commits

Restricted Diffusion Commit
rP76d4e85bfc1b: Only hide archived project tags on workboard cards

Summary

Fixes T10413. I accidentally hid these everywhere, but only intended to hide them on workboards.

Test Plan

Viewed a workboard, saw un-archived projects only.
Viewed a task detail page, saw archived and un-archived projects.

Diff Detail

Repository

rP Phabricator

Branch

dishadndle

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10825
Build 13340: Run Core Tests
Build 13339: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36985.Feb 23 2016, 6:45 PM

epriestley retitled this revision from to Only hide archived project tags on workboard cards.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10413: Archived project tags are hidden everywhere, not just on Workboard cards.

chad accepted this revision.Feb 23 2016, 6:47 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 23 2016, 6:47 PM

Closed by commit rP76d4e85bfc1b: Only hide archived project tags on workboard cards (authored by epriestley, committed by epriestley). · Explain WhyFeb 23 2016, 6:47 PM

This revision was automatically updated to reflect the committed changes.

• Persona added a child revision: D15341: Fix Ponder Exception, spacing.Feb 24 2016, 11:16 AM

tycho.tatitscheff removed a child revision: D15341: Fix Ponder Exception, spacing.Feb 24 2016, 12:31 PM

epriestley mentioned this in D18783: Hide archived projects only on workboards, not hovercards.Nov 27 2017, 10:13 PM

epriestley mentioned this in rP00baa3c1dd9b: Hide archived projects only on workboards, not hovercards.Nov 27 2017, 10:37 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

phid/

view/

PHUIHandleTagListView.php

7 lines

project/

view/

ProjectBoardTaskCard.php

10 lines

Diff 36985

View Options

src/applications/phid/view/PHUIHandleTagListView.php