Differential D15307

Return 404 instead of undefined variable error when trying to edit a non-existent form
ClosedPublic
Actions

Authored by Krenair on Feb 18 2016, 5:53 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPf557fc9caab1: Return 404 instead of undefined variable error when trying to edit a non…

Summary

E.g. https://phab-01.wmflabs.org/transactions/editengine/transactions.editengine.config/view/13/

Test Plan

Go to /transactions/editengine/transactions.editengine.config/view/1000000/
Observe error
Apply patch
Observe 404

Diff Detail

Repository

rP Phabricator

Branch

undefined-engine

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10760
Build 13247: arc lint + arc unit

Event Timeline

Krenair updated this revision to Diff 36917.Feb 18 2016, 5:53 PM

Krenair retitled this revision from to Return 404 instead of undefined variable error when trying to edit a non-existent form.

Krenair updated this object.

Krenair edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 18 2016, 5:53 PM

Herald added a subscriber: epriestley. · View Herald Transcript

Thanks!

This revision is now accepted and ready to land.Feb 18 2016, 5:54 PM

Closed by commit rPf557fc9caab1: Return 404 instead of undefined variable error when trying to edit a non… (authored by Krenair, committed by epriestley). · Explain WhyFeb 18 2016, 5:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

controller/

PhabricatorEditEngineController.php

2 lines

Diff 36917

View Options

src/applications/transactions/controller/PhabricatorEditEngineController.php

Return 404 instead of undefined variable error when trying to edit a non-existent formClosedPublicActions