Page MenuHomePhabricator
Differential D15303

Don't require a callsign to set a repository's local path
ClosedPublic
Actions

Authored by epriestley on Feb 18 2016, 1:29 PM.
Tags
None
Referenced Files
F15485762: D15303.id36922.diff
Thu, Apr 10, 2:06 AM
F15455236: D15303.id36922.diff
Sat, Mar 29, 11:02 PM
F15447543: D15303.diff
Fri, Mar 28, 12:32 AM
F15437625: D15303.id36912.diff
Tue, Mar 25, 8:42 PM
F15434353: D15303.id36912.diff
Tue, Mar 25, 3:06 AM
F15434352: D15303.id.diff
Tue, Mar 25, 3:06 AM
F15434351: D15303.id36922.diff
Tue, Mar 25, 3:06 AM
F15434288: D15303.diff
Tue, Mar 25, 2:54 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4245: Make repository URIs slightly prettier
Commits
Restricted Diffusion Commit
rPb63eb09cacf1: Don't require a callsign to set a repository's local path
Summary

Ref T4245. When creating new repositories, set a default local path based on the repository ID instead of callsign.

Test Plan
  • Created a new repository.
  • Saw it get a reasonable, ID-based local path.
  • Edited a repository to make sure the applyFinalEffects() wasn't doing anything whacky.

Diff Detail

Repository
rP Phabricator
Branch
call9
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10755
Build 13238: Run Core Tests
Build 13237: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36912.Feb 18 2016, 1:29 PM
epriestley retitled this revision from to Don't require a callsign to set a repository's local path.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4245: Make repository URIs slightly prettier.
chad accepted this revision.Feb 18 2016, 4:16 PM
chad edited edge metadata.

6dd.png (600×600 px, 94 KB)

This revision is now accepted and ready to land.Feb 18 2016, 4:16 PM
Closed by commit rPb63eb09cacf1: Don't require a callsign to set a repository's local path (authored by epriestley, committed by epriestley). · Explain WhyFeb 18 2016, 6:33 PM
This revision was automatically updated to reflect the committed changes.
• Persona added a child revision: D15341: Fix Ponder Exception, spacing.Feb 24 2016, 11:16 AM
tycho.tatitscheff removed a child revision: D15341: Fix Ponder Exception, spacing.Feb 24 2016, 12:31 PM

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
11 lines
repository/
editor/
23 lines

Diff 36912

View Options

src/applications/diffusion/controller/DiffusionRepositoryCreateController.php

Loading...
View Options

src/applications/repository/editor/PhabricatorRepositoryEditor.php

Loading...
Phabricator · Built by Phacility