Page MenuHomePhabricator

Improve subproject/milestone error handling for users who can't create projects
ClosedPublic

Authored by epriestley on Feb 15 2016, 3:22 PM.
Tags
None
Referenced Files
F14838033: D15274.diff
Fri, Jan 31, 1:03 PM
Unknown Object (File)
Thu, Jan 30, 10:50 AM
Unknown Object (File)
Thu, Jan 30, 1:27 AM
Unknown Object (File)
Mon, Jan 27, 5:40 PM
Unknown Object (File)
Fri, Jan 24, 11:50 AM
Unknown Object (File)
Fri, Jan 24, 11:50 AM
Unknown Object (File)
Fri, Jan 24, 11:50 AM
Unknown Object (File)
Mon, Jan 20, 8:29 PM
Subscribers
None

Details

Summary

Fixes T10357.

  • Show a better (more descriptive) error message when a user who can't create projects tries to create a subproject or milestone.
  • Disable the subproject actions if you don't have create permission.

All this stuff was already enforced properly: this diff doesn't make any actual policy changes, just improves the UI for users who lack permission.

Test Plan
  • As an unprivileged user (no "Can Create Projects"), tried to create a subproject or milestone.
  • After patch, got a disabled action, with more specific and helpful error than before.

Diff Detail

Repository
rP Phabricator
Branch
bperm1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10696
Build 13144: Run Core Tests
Build 13143: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Improve subproject/milestone error handling for users who can't create projects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 15 2016, 3:29 PM
This revision was automatically updated to reflect the committed changes.