Page MenuHomePhabricator

Filter out archived projects from ProjectProfileView
ClosedPublic

Authored by chad on Feb 12 2016, 8:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 10:23 PM
Unknown Object (File)
Tue, Dec 17, 8:45 AM
Unknown Object (File)
Sat, Dec 14, 3:13 PM
Unknown Object (File)
Thu, Nov 28, 11:56 AM
Unknown Object (File)
Sat, Nov 23, 7:58 PM
Unknown Object (File)
Sat, Nov 23, 9:56 AM
Unknown Object (File)
Oct 21 2024, 9:45 PM
Unknown Object (File)
Oct 20 2024, 3:39 PM
Subscribers

Details

Summary

This just hides them, should still show on "View All".

Test Plan

Hide a Milestone, no longer see it on home. Click "View All", see all Milestones.

Diff Detail

Repository
rP Phabricator
Branch
show-archived (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10674
Build 13111: Run Core Tests
Build 13110: arc lint + arc unit

Event Timeline

chad retitled this revision from to Filter out archived projects from ProjectProfileView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

We should possibly do something like: if this gets zero results, query again without the filter, then show the disabled stuff. Currently, we'll probably show a misleading message ("This project has no milestones") if a project has milestones/subprojects but they're all archived. But we can wait until someone complains.

This revision is now accepted and ready to land.Feb 12 2016, 8:35 PM

Oh -- we don't show any misleading text, we just hide the element. That seems perfectly fine.

This revision was automatically updated to reflect the committed changes.