Page MenuHomePhabricator
Differential D15250

Add `transactionID` to maniphest.gettransactions output
ClosedPublic
Actions

Authored by • jshirley on Feb 11 2016, 8:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 1:58 AM
Unknown Object (File)
Wed, Dec 18, 6:20 AM
Unknown Object (File)
Wed, Dec 18, 3:02 AM
Unknown Object (File)
Wed, Dec 18, 1:09 AM
Unknown Object (File)
Wed, Dec 18, 1:09 AM
Unknown Object (File)
Wed, Dec 11, 2:28 AM
Unknown Object (File)
Thu, Dec 5, 8:42 PM
Unknown Object (File)
Thu, Nov 28, 4:06 PM
View All Files
Subscribers
chad
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP8af3abc40a66: Add `transactionID` to maniphest.gettransactions output
Required Signatures
L28 Phacility Individual Contributor License Agreement
Summary

This commit adds the transactionID field to manphest.gettransactions, to
satisfy the request in T10327

Test Plan

Call the maniphest.gettransactions endpoint, verify transactionID is present

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10644
Build 13066: arc lint + arc unit

Event Timeline

• jshirley updated this revision to Diff 36802.Feb 11 2016, 8:56 PM
• jshirley retitled this revision from to Add `transactionID` to maniphest.gettransactions output.
• jshirley updated this object.
• jshirley edited the test plan for this revision. (Show Details)
• jshirley added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 11 2016, 8:56 PM
Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript
Herald added a subscriber: Korvin. · View Herald Transcript
• jshirley added a comment.Feb 11 2016, 8:57 PM

I signed the Corporate CLA, do I need to do the individual record or does this just need something outside of what I can see/do with secure.phabricator.com?

epriestley edited edge metadata.Feb 11 2016, 8:58 PM

I just need to manually kick you into a list of associated users on our side, gimmie a sec.

epriestley accepted this revision.Feb 11 2016, 9:00 PM
epriestley edited edge metadata.

I added you to Blessed Committers so you should be able to Land Revision here in the web UI or arc land this yourself.

(If you run into trouble or are pointed at some proxy remote or something so this is all a big pain, just yell and I'll pull it.)

This revision is now accepted and ready to land.Feb 11 2016, 9:00 PM
chad added a subscriber: chad.Feb 11 2016, 9:20 PM
In D15250#175210, @epriestley wrote:

I added you to Blessed Committers so you should be able to Land Revision here in the web UI or arc land this yourself.

(If you run into trouble or are pointed at some proxy remote or something so this is all a big pain, just yell and I'll pull it.)

awwyiss

• jshirley added a comment.Feb 12 2016, 3:47 PM

Looks like I can't? Running from the command line it says that permission is denied, through the Web UI it's less informative or I don't know where to look: https://secure.phabricator.com/drydock/operation/106/

Thanks though :-D

epriestley added a comment.Feb 12 2016, 3:49 PM

I'll just pull this for now, we can figure out what's up next time.

Closed by commit rP8af3abc40a66: Add `transactionID` to maniphest.gettransactions output (authored by • jshirley, committed by epriestley). · Explain WhyFeb 12 2016, 3:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
conduit/
1 line

Diff 36802

View Options

src/applications/maniphest/conduit/ManiphestGetTaskTransactionsConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility