Differential D15246

Add commit id to header in Diffusion
ClosedPublic
Actions

Authored by chad on Feb 11 2016, 7:31 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T7628: Diffusion commit pages should mention plain commit hash somewhere

Commits

Restricted Diffusion Commit
rPa39d0344c643: Add commit id to header in Diffusion

Summary

Also adds the commit to the header underneath the title. Ref T7628

Test Plan

Review a few Diffusion pages.

Diff Detail

Repository

rP Phabricator

Branch

diffusion-header (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10638
Build 13058: Run Core Tests
Build 13057: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 36796.Feb 11 2016, 7:31 PM

chad retitled this revision from to Add commit id to header in Diffusion.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T7628: Diffusion commit pages should mention plain commit hash somewhere.

Herald added a subscriber: Korvin. · View Herald TranscriptFeb 11 2016, 7:31 PM

epriestley accepted this revision.Feb 11 2016, 7:32 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Feb 11 2016, 7:32 PM

Closed by commit rPa39d0344c643: Add commit id to header in Diffusion (authored by chad, committed by chad). · Explain WhyFeb 11 2016, 7:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionCommitController.php

5 lines

Diff 36796

View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Add commit id to header in DiffusionClosedPublicActions