Page MenuHomePhabricator
Differential D15242

Fix an issue with creating tasks directly into milestone columns
ClosedPublic
Actions

Authored by epriestley on Feb 11 2016, 5:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 12:09 AM
Unknown Object (File)
Thu, Dec 12, 4:31 PM
Unknown Object (File)
Mon, Dec 2, 9:30 PM
Unknown Object (File)
Wed, Nov 27, 3:16 AM
Unknown Object (File)
Sat, Nov 23, 1:35 PM
Unknown Object (File)
Nov 19 2024, 3:02 AM
Unknown Object (File)
Nov 15 2024, 1:57 PM
Unknown Object (File)
Nov 14 2024, 4:15 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rPad77b014f10e: Fix an issue with creating tasks directly into milestone columns
Summary

These columns were conflating projectPHID (the defualt project to add to the task) with boardPHID (the board the column appears on).

Separate them to fix the beahvior.

Test Plan

Used "Add Task" from dropdown menu of a milestone column on a parent project's workboard.

Diff Detail

Repository
rP Phabricator
Branch
mile2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10629
Build 13045: Run Core Tests
Build 13044: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36787.Feb 11 2016, 5:52 PM
epriestley retitled this revision from to Fix an issue with creating tasks directly into milestone columns.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Feb 11 2016, 5:54 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 11 2016, 5:54 PM
Closed by commit rPad77b014f10e: Fix an issue with creating tasks directly into milestone columns (authored by epriestley, committed by epriestley). · Explain WhyFeb 11 2016, 6:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
24 lines
src/
applications/
project/
controller/
1 line
webroot/
rsrc/
js/
application/
projects/
4 lines

Diff 36787

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...
View Options

webroot/rsrc/js/application/projects/WorkboardController.js

Loading...
Phabricator · Built by Phacility