Page MenuHomePhabricator
Differential D15239

Allow "0" to be a valid workboard column point limit
ClosedPublic
Actions

Authored by epriestley on Feb 10 2016, 11:08 PM.
Tags
None
Referenced Files
F15484191: D15239.id36782.diff
Wed, Apr 9, 4:58 PM
F15481777: D15239.id36783.diff
Tue, Apr 8, 10:47 PM
F15468609: D15239.id.diff
Fri, Apr 4, 2:57 AM
F15468033: D15239.diff
Thu, Apr 3, 7:38 PM
F15414568: D15239.id36783.diff
Thu, Mar 20, 1:13 AM
F15377995: D15239.diff
Thu, Mar 13, 11:59 AM
F15339105: D15239.id36783.diff
Mar 9 2025, 2:25 PM
F15335905: D15239.diff
Mar 8 2025, 5:40 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T6580: allow workboard columns to have a point limit of 0
Commits
Restricted Diffusion Commit
rP0b5abf7bb51a: Allow "0" to be a valid workboard column point limit
Summary

Fixes T6580. Now:

  • Empty field means "unlimited".
  • Zero means 0.
  • Nonzero means that number.

(Although you can now have fractional points, I didn't change columns to allow fractional limits, because too bad.)

Test Plan

Screen Shot 2016-02-10 at 3.06.11 PM.png (1×1 px, 116 KB)

Diff Detail

Repository
rP Phabricator
Branch
zlimit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10624
Build 13037: Run Core Tests
Build 13036: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36782.Feb 10 2016, 11:08 PM
epriestley retitled this revision from to Allow "0" to be a valid workboard column point limit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T6580: allow workboard columns to have a point limit of 0.
chad accepted this revision.Feb 10 2016, 11:09 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 10 2016, 11:09 PM
Closed by commit rP0b5abf7bb51a: Allow "0" to be a valid workboard column point limit (authored by epriestley, committed by epriestley). · Explain WhyFeb 10 2016, 11:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
66 lines
src/
applications/
project/
controller/
9 lines
editor/
10 lines

Diff 36782

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectColumnDetailController.php

Loading...
View Options

src/applications/project/editor/PhabricatorProjectColumnTransactionEditor.php

Loading...
Phabricator · Built by Phacility