Page MenuHomePhabricator

Allow "0" to be a valid workboard column point limit
ClosedPublic

Authored by epriestley on Feb 10 2016, 11:08 PM.
Tags
None
Referenced Files
F14784786: D15239.diff
Fri, Jan 24, 11:44 AM
Unknown Object (File)
Wed, Jan 8, 4:25 AM
Unknown Object (File)
Sun, Jan 5, 9:49 AM
Unknown Object (File)
Wed, Jan 1, 3:48 AM
Unknown Object (File)
Dec 18 2024, 1:08 AM
Unknown Object (File)
Dec 17 2024, 6:50 AM
Unknown Object (File)
Dec 16 2024, 9:16 PM
Unknown Object (File)
Dec 16 2024, 9:16 PM
Subscribers
None

Details

Summary

Fixes T6580. Now:

  • Empty field means "unlimited".
  • Zero means 0.
  • Nonzero means that number.

(Although you can now have fractional points, I didn't change columns to allow fractional limits, because too bad.)

Test Plan

Screen Shot 2016-02-10 at 3.06.11 PM.png (1×1 px, 116 KB)

Diff Detail

Repository
rP Phabricator
Branch
zlimit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10624
Build 13037: Run Core Tests
Build 13036: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Allow "0" to be a valid workboard column point limit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 10 2016, 11:09 PM
This revision was automatically updated to reflect the committed changes.