Fix a bad call when prefilling ApplicationSearch from `?projects=some_slug`
ClosedPublic
Actions

Authored by epriestley on Feb 8 2016, 6:28 PM.

Details

Reviewers

chad

Maniphest Tasks

T10299: Maniphest search with slugs results in error

Commits

Restricted Diffusion Commit
rP07f1a03262d5: Fix a bad call when prefilling ApplicationSearch from `?projects=some_slug`

Summary

Fixes T10299.

Test Plan

Visited /maniphest/?projects=x locally, where x is some valid project slug.
Before patch: Fatal on requireViewer() call.
After patch: Works correctly, filling the correct project into parameters.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36727.Feb 8 2016, 6:28 PM

epriestley retitled this revision from to Fix a bad call when prefilling ApplicationSearch from `?projects=some_slug`.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10299: Maniphest search with slugs results in error.

epriestley mentioned this in T10299: Maniphest search with slugs results in error.Feb 8 2016, 6:29 PM

chad accepted this revision.Feb 8 2016, 6:35 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 8 2016, 6:35 PM

Closed by commit rP07f1a03262d5: Fix a bad call when prefilling ApplicationSearch from `?projects=some_slug` (authored by epriestley, committed by epriestley). · Explain WhyFeb 8 2016, 6:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

searchfield/

PhabricatorProjectSearchField.php

2 lines

Diff 36728

View Options

src/applications/project/searchfield/PhabricatorProjectSearchField.php

Fix a bad call when prefilling ApplicationSearch from `?projects=some_slug`ClosedPublicActions