Page MenuHomePhabricator
Differential D15198

Add a coverImage field to PHUIObjectItemView
ClosedPublic
Actions

Authored by chad on Feb 6 2016, 8:00 PM.
Tags
None
Referenced Files
F13241296: D15198.id.diff
Wed, May 22, 8:07 PM
F13232807: D15198.diff
Tue, May 21, 1:29 AM
Unknown Object (File)
Thu, Apr 25, 9:13 AM
Unknown Object (File)
Apr 21 2024, 6:18 AM
Unknown Object (File)
Apr 16 2024, 2:16 AM
Unknown Object (File)
Apr 9 2024, 6:46 PM
Unknown Object (File)
Apr 9 2024, 11:49 AM
Unknown Object (File)
Apr 5 2024, 12:10 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP5523217fbb2d: Add a coverImage field to PHUIObjectItemView
Summary

Allows setting of an image to a Workboard card. (Hides from regular view, just in case).

Test Plan

Fake setting a Pholio Mock image.

Diff Detail

Repository
rP Phabricator
Branch
oil-3 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10532
Build 12899: Run Core Tests
Build 12898: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 36691.Feb 6 2016, 8:00 PM
chad retitled this revision from to Add a coverImage field to PHUIObjectItemView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptFeb 6 2016, 8:00 PM
epriestley accepted this revision.Feb 6 2016, 8:03 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 6 2016, 8:03 PM
Closed by commit rP5523217fbb2d: Add a coverImage field to PHUIObjectItemView (authored by chad, committed by chad). · Explain WhyFeb 6 2016, 8:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
src/
view/
phui/
39 lines
webroot/
rsrc/
css/
phui/
4 lines
workboards/
6 lines

Diff 36691

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/PHUIObjectItemView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...
View Options

webroot/rsrc/css/phui/workboards/phui-workcard.css

Loading...
Phabricator · Built by Phacility