Differential D15175

Continue lifting column layout logic out of ColumnPositionQuery
ClosedPublic
Actions

Authored by epriestley on Feb 3 2016, 7:07 PM.

Details

Reviewers

chad

Maniphest Tasks

T10010: Implement Subprojects

Commits

Restricted Diffusion Commit
rPa9e98e42f5ff: Continue lifting column layout logic out of ColumnPositionQuery

Summary

Ref T10010. See D15174. This gets rid of the "actually apply the change" callsite and moves it to layout engine.

Next up is to make the board view use the layout engine, then throw away all the whack code in ColumnPositionQuery, then move forward with D15171.

Test Plan

Dragged tasks within a column.
Dragged tasks between columns.
Dragged tasks to empty columns.
Created a task in a column.
Swapped board to priority sort, dragged a bunch of stuff all over.

Diff Detail

Repository

rP Phabricator

Branch

col3

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/maniphest/editor/ManiphestTransactionEditor.php:242	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 10474
Build 12811: Run Core Tests
Build 12810: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36633.Feb 3 2016, 7:07 PM

epriestley retitled this revision from to Continue lifting column layout logic out of ColumnPositionQuery.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10010: Implement Subprojects.

Remove giant debugging block.

Will all this stuff be testable?

This revision is now accepted and ready to land.Feb 3 2016, 7:50 PM

Yeah, that's one of the big advantages of doing it this way. A big part of this is ultimately UI stuff so there are limits to how much I can reasonably cover, but the basic "moving stuff around" operations should be fairly testable once I get the new thing in place.

Closed by commit rPa9e98e42f5ff: Continue lifting column layout logic out of ColumnPositionQuery (authored by epriestley, committed by epriestley). · Explain WhyFeb 3 2016, 11:05 PM

This revision was automatically updated to reflect the committed changes.