Page MenuHomePhabricator

Continue lifting column layout logic out of ColumnPositionQuery
ClosedPublic

Authored by epriestley on Feb 3 2016, 7:07 PM.
Tags
None
Referenced Files
F11412334: D15175.diff
Thu, Dec 8, 5:35 AM
Unknown Object (File)
Tue, Nov 29, 7:55 PM
Unknown Object (File)
Tue, Nov 29, 7:55 PM
Unknown Object (File)
Tue, Nov 29, 7:55 PM
Unknown Object (File)
Tue, Nov 29, 7:55 PM
Unknown Object (File)
Wed, Nov 16, 3:51 PM
Unknown Object (File)
Wed, Nov 16, 6:45 AM
Unknown Object (File)
Fri, Nov 11, 7:57 AM
Subscribers
None

Details

Summary

Ref T10010. See D15174. This gets rid of the "actually apply the change" callsite and moves it to layout engine.

Next up is to make the board view use the layout engine, then throw away all the whack code in ColumnPositionQuery, then move forward with D15171.

Test Plan
  • Dragged tasks within a column.
  • Dragged tasks between columns.
  • Dragged tasks to empty columns.
  • Created a task in a column.
  • Swapped board to priority sort, dragged a bunch of stuff all over.

Diff Detail

Repository
rP Phabricator
Branch
col3
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/maniphest/editor/ManiphestTransactionEditor.php:251XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 10473
Build 12809: Run Core Tests
Build 12808: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Continue lifting column layout logic out of ColumnPositionQuery.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Remove giant debugging block.
chad edited edge metadata.

Will all this stuff be testable?

This revision is now accepted and ready to land.Feb 3 2016, 7:50 PM

Yeah, that's one of the big advantages of doing it this way. A big part of this is ultimately UI stuff so there are limits to how much I can reasonably cover, but the basic "moving stuff around" operations should be fairly testable once I get the new thing in place.

This revision was automatically updated to reflect the committed changes.