Swap charts from gRaphael to D3
ClosedPublic
Actions

Authored by epriestley on Feb 1 2016, 6:03 PM.

Details

Reviewers

chad

Commits

Restricted Diffusion Commit
rPf5c686d6a4c5: Swap charts from gRaphael to D3

Summary

Mostly, this has just been sitting in my sandbox for a long time. I may also touch some charting stuff with subprojects/milestones, but don't have particular plans to do that.

D3 seems a bit more flexible, and it's easier to push more of the style logic into CSS so you can fix my design atrocities. gRaphael also hasn't been updated in ~3+ years.

Test Plan

Screen Shot 2016-02-01 at 9.55.48 AM.png (1×2 px, 184 KB)

Screen Shot 2016-02-01 at 9.55.54 AM.png (1×2 px, 207 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36589.Feb 1 2016, 6:03 PM

epriestley retitled this revision from to Swap charts from gRaphael to D3.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

Herald edited edge metadata. · View Herald TranscriptFeb 1 2016, 6:03 PM

Herald added a subscriber: yelirekim. · View Herald Transcript

chad accepted this revision.Feb 1 2016, 6:05 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 1 2016, 6:05 PM

cburroughs added a subscriber: cburroughs.Feb 1 2016, 6:22 PM

cburroughs added inline comments.

src/applications/celerity/CelerityResourceTransformer.php
69	Does this really happen to be true of both charting libraries?

epriestley added inline comments.Feb 1 2016, 6:23 PM

src/applications/celerity/CelerityResourceTransformer.php
69	"Yes", in the sense of "they are both already minified so there's no reason to reprocess them". I didn't actually check if `d3.min.js` really breaks when run through our proprocessors.