Page MenuHomePhabricator
Differential D15141

Move code examples in remarkup to grey backgrounds
ClosedPublic
Actions

Authored by chad on Jan 29 2016, 8:25 PM.
Tags
None
Referenced Files
F13263032: D15141.diff
Mon, May 27, 6:28 AM
F13245419: D15141.diff
Thu, May 23, 6:00 AM
F13195934: D15141.diff
Sun, May 12, 10:46 PM
F13192176: D15141.diff
Sun, May 12, 6:06 AM
F13178581: D15141.diff
Wed, May 8, 8:31 PM
Unknown Object (File)
Apr 25 2024, 3:03 AM
Unknown Object (File)
Apr 17 2024, 6:41 PM
Unknown Object (File)
Apr 6 2024, 10:33 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP8c3f355a9543: Move code examples in remarkup to grey backgrounds
Summary

This should make code easier to read. Right now large blocks get a really bright treatment, and this should tone it down. Also upped the spacing a bit.

Test Plan

Review Remarkup Examples from Diviner, also some test code blocks and counter examples.

pasted_file (969×1 px, 149 KB)

pasted_file (725×870 px, 103 KB)

Diff Detail

Repository
rP Phabricator
Branch
tt-in-a-header (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10394
Build 12688: Run Core Tests
Build 12687: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 36555.Jan 29 2016, 8:25 PM
chad retitled this revision from to Move code examples in remarkup to grey backgrounds.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptJan 29 2016, 8:25 PM
epriestley accepted this revision.Jan 29 2016, 8:26 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 29 2016, 8:26 PM
chad edited the test plan for this revision. (Show Details)Jan 29 2016, 8:26 PM
chad edited edge metadata.

(if you hate these tho, lemme kno, bro)

Closed by commit rP8c3f355a9543: Move code examples in remarkup to grey backgrounds (authored by chad, committed by chad). · Explain WhyJan 29 2016, 8:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
webroot/
rsrc/
css/
core/
25 lines
phui/
4 lines

Diff 36555

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/core/remarkup.css

Loading...
View Options

webroot/rsrc/css/phui/phui-document.css

Loading...
Phabricator · Built by Phacility