Page MenuHomePhabricator
Differential D15137

Rework Workboard Cards, split up CSS
ClosedPublic
Actions

Authored by chad on Jan 29 2016, 5:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 11:46 AM
Unknown Object (File)
Thu, Dec 12, 9:28 AM
Unknown Object (File)
Mon, Dec 9, 12:25 AM
Unknown Object (File)
Sat, Dec 7, 9:49 PM
Unknown Object (File)
Fri, Dec 6, 3:53 AM
Unknown Object (File)
Sun, Dec 1, 10:38 AM
Unknown Object (File)
Tue, Nov 26, 8:56 PM
Unknown Object (File)
Tue, Nov 26, 10:47 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP4d498466c303: Rework Workboard Cards, split up CSS
Summary

Moves CSS into 3 files, Boards, Panels, Cards. Cleans up Workcards to present more info, hide edit until card hover.

Test Plan

Lots of photoshop. Verify links to edit still work.

pasted_file (572×813 px, 114 KB)

Diff Detail

Repository
rP Phabricator
Branch
workboards-4 (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10384
Build 12672: Run Core Tests
Build 12671: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 36545.Jan 29 2016, 5:29 PM
chad retitled this revision from to Rework Workboard Cards, split up CSS.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptJan 29 2016, 5:29 PM
chad edited the test plan for this revision. (Show Details)Jan 29 2016, 5:30 PM
epriestley edited edge metadata.Jan 29 2016, 5:32 PM

How do I edit on mobile?

Screen Shot 2016-01-29 at 9.31.28 AM.png (1×752 px, 199 KB)

chad added a comment.Jan 29 2016, 5:45 PM

I can add it back for mobile, but honestly I'd probably prefer to send them to the task itself.

chad updated this revision to Diff 36546.Jan 29 2016, 5:49 PM
chad edited edge metadata.
  • Restrict hover edit to desktops
chad added a comment.Jan 29 2016, 5:49 PM

actually editing is not terrible on mobile.

epriestley added a comment.Jan 29 2016, 5:51 PM

Edit -> Save -> no way to get back to workboard feels like it might be fairly bad to me. Do you think that's not such a big deal?

chad added a comment.Jan 29 2016, 5:52 PM

No you're right. I was thinking editing on mobile dialog was likely a bad experience, but it's nearly the same as editing on the task. I've restricted the hover edit to just desktops.

epriestley accepted this revision.Jan 29 2016, 5:53 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 29 2016, 5:53 PM
chad updated this revision to Diff 36547.Jan 29 2016, 5:53 PM
chad edited edge metadata.
  • make panels 0 width on mobile
Closed by commit rP4d498466c303: Rework Workboard Cards, split up CSS (authored by chad, committed by chad). · Explain WhyJan 29 2016, 5:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
13 lines
webroot/
rsrc/
css/
phui/
workboards/
phui-workboard.css
phui-workboard-view.css
6 lines
workboards/
125 lines
100 lines

Diff 36545

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/phui/phui-workboard-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-workpanel-view.css

Loading...
View Options

webroot/rsrc/css/phui/workboards/phui-workboard.css

Loading...
View Options

webroot/rsrc/css/phui/workboards/phui-workcard.css

Loading...
View Options

webroot/rsrc/css/phui/workboards/phui-workpanel.css

Loading...
Phabricator · Built by Phacility