Page MenuHomePhabricator
Differential D15132

Minor tweaks to Profile/Project
ClosedPublic
Actions

Authored by chad on Jan 28 2016, 9:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 6:18 AM
Unknown Object (File)
Wed, Dec 18, 6:18 AM
Unknown Object (File)
Wed, Dec 18, 1:04 AM
Unknown Object (File)
Sat, Dec 14, 5:14 PM
Unknown Object (File)
Sat, Dec 14, 2:35 PM
Unknown Object (File)
Sat, Dec 14, 12:05 AM
Unknown Object (File)
Sun, Dec 8, 5:31 AM
Unknown Object (File)
Mon, Nov 25, 1:28 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP5e639feab40e: Minor tweaks to Profile/Project
Summary
  • Redirect to profileview when new image is uploaded.
  • Add ProfileNav to EditPicture on Profile
  • Add ProfileNav to EditProfile on Profile
Test Plan

Set new images on Profiles and Projects. See new redirect. See new navs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 36535.Jan 28 2016, 9:32 PM
chad retitled this revision from to Minor tweaks to Profile/Project.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptJan 28 2016, 9:32 PM
epriestley accepted this revision.Jan 28 2016, 10:43 PM
epriestley edited edge metadata.

Redirect seems a little weird -- this is for click-the-image cases?

We could make it contextual so it knows which page to kick you back to, but that's kind of a pain. Maybe I'll shoot you a diff if I ever hit it.

This revision is now accepted and ready to land.Jan 28 2016, 10:43 PM
chad added a comment.Jan 28 2016, 10:44 PM

It feels more natural when I use it, I'm tempted to just remove "set picture" action from the manage page.

Closed by commit rP5e639feab40e: Minor tweaks to Profile/Project (authored by chad, committed by chad). · Explain WhyJan 28 2016, 10:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 36536

View Options

src/applications/people/controller/PhabricatorPeopleProfileEditController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleProfilePictureController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectEditPictureController.php

Loading...
Phabricator · Built by Phacility