Page MenuHomePhabricator

Minor tweaks to Profile/Project
ClosedPublic

Authored by chad on Jan 28 2016, 9:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 12:37 AM
Unknown Object (File)
Sun, Feb 9, 12:37 AM
Unknown Object (File)
Sun, Feb 9, 12:37 AM
Unknown Object (File)
Sun, Feb 9, 12:37 AM
Unknown Object (File)
Tue, Feb 4, 7:21 PM
Unknown Object (File)
Tue, Jan 28, 4:44 AM
Unknown Object (File)
Sun, Jan 26, 5:41 AM
Unknown Object (File)
Fri, Jan 24, 11:28 AM
Subscribers

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP5e639feab40e: Minor tweaks to Profile/Project
Summary
  • Redirect to profileview when new image is uploaded.
  • Add ProfileNav to EditPicture on Profile
  • Add ProfileNav to EditProfile on Profile
Test Plan

Set new images on Profiles and Projects. See new redirect. See new navs.

Diff Detail

Repository
rP Phabricator
Branch
photo-redirect (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10374
Build 12656: Run Core Tests
Build 12655: arc lint + arc unit

Event Timeline

chad retitled this revision from to Minor tweaks to Profile/Project.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

Redirect seems a little weird -- this is for click-the-image cases?

We could make it contextual so it knows which page to kick you back to, but that's kind of a pain. Maybe I'll shoot you a diff if I ever hit it.

This revision is now accepted and ready to land.Jan 28 2016, 10:43 PM

It feels more natural when I use it, I'm tempted to just remove "set picture" action from the manage page.

This revision was automatically updated to reflect the committed changes.