Page MenuHomePhabricator
Differential D15125

Convert all calls to 'IconFont' to just 'Icon'
ClosedPublic
Actions

Authored by chad on Jan 28 2016, 3:00 AM.
Tags
None
Referenced Files
F14023401: D15125.id36517.diff
Thu, Nov 7, 1:42 AM
F14023400: D15125.id36515.diff
Thu, Nov 7, 1:37 AM
F14023399: D15125.id36516.diff
Thu, Nov 7, 1:37 AM
F13993492: D15125.id36516.diff
Tue, Oct 22, 11:10 PM
F13989233: D15125.diff
Mon, Oct 21, 7:07 PM
F13987193: D15125.id36515.diff
Mon, Oct 21, 8:01 AM
F13979394: D15125.id36520.diff
Oct 19 2024, 4:14 AM
F13969298: D15125.id36515.largetrue.diff
Oct 17 2024, 1:46 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP36158dbdc081: Convert all calls to 'IconFont' to just 'Icon'
Summary

Mostly for consistency, we're not using other forms of icons and this makes all classes that use an icon call it in the same way.

Test Plan

tested uiexamples, lots of other random pages.

Diff Detail

Repository
rP Phabricator
Branch
iconfont (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10357
Build 12631: Run Core Tests
Build 12630: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 36515.Jan 28 2016, 3:00 AM
chad retitled this revision from to Convert all calls to 'IconFont' to just 'Icon'.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptJan 28 2016, 3:00 AM
chad updated this revision to Diff 36516.Jan 28 2016, 3:55 AM
  • manual adjustments
chad updated this revision to Diff 36517.Jan 28 2016, 4:40 AM
  • more manual adjustments
epriestley accepted this revision.Jan 28 2016, 4:51 AM
epriestley edited edge metadata.

Nice! This one's been bugging me a tiny bit, too.

This revision is now accepted and ready to land.Jan 28 2016, 4:51 AM
Closed by commit rP36158dbdc081: Convert all calls to 'IconFont' to just 'Icon' (authored by chad, committed by chad). · Explain WhyJan 28 2016, 4:59 AM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Jan 28 2016, 5:01 AM

Yeah I want to clean up "FontIcon" next.

epriestley mentioned this in Z1336: General Chat.Jan 28 2016, 7:18 PM

Large Diff

This large diff affects 130 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
src/
applications/
almanac/
controller/
8 lines
10 lines
4 lines
auth/
controller/
config/
4 lines
data/
2 lines
view/
4 lines
base/
controller/
2 lines
calendar/
controller/
6 lines
chatlog/
controller/
2 lines
conduit/
query/
6 lines
settings/
8 lines
config/
controller/
11 lines
6 lines
2 lines
module/
4 lines
conpherence/
controller/
2 lines
query/
2 lines
view/
6 lines
2 lines
4 lines
dashboard/
engine/
6 lines
paneltype/
2 lines
differential/
constants/
2 lines
view/
2 lines
4 lines
2 lines
diffusion/
controller/
8 lines
4 lines
14 lines
view/
2 lines
6 lines
diviner/
controller/
2 lines
5 lines
drydock/
controller/
4 lines
6 lines
2 lines
view/
2 lines
files/
controller/
4 lines
2 lines
iconset/
2 lines
harbormaster/
controller/
4 lines
4 lines
herald/
adapter/
2 lines
home/
controller/
2 lines
legalpad/
controller/
4 lines
query/
4 lines
6 lines
macro/
markup/
2 lines
maniphest/
constants/
2 lines
metamta/
applicationpanel/
6 lines
notification/
controller/
2 lines
query/
2 lines
people/
controller/
2 lines
2 lines
phame/
controller/
2 lines
blog/
2 lines
post/
2 lines
view/
2 lines
2 lines
4 lines
phid/
2 lines
pholio/
view/
4 lines
2 lines
phortune/
controller/
8 lines
10 lines
3 lines
2 lines
4 lines
view/
2 lines
phriction/
controller/
2 lines
policy/
storage/
2 lines
ponder/
view/
4 lines
4 lines
project/
controller/
4 lines
2 lines
2 lines
2 lines
query/
2 lines
view/
2 lines
4 lines
search/
engine/
6 lines
profilepanel/
2 lines
settings/
panel/
4 lines
5 lines
4 lines
8 lines
8 lines
9 lines
5 lines
transactions/
controller/
2 lines
editengine/
2 lines
view/
4 lines
typeahead/
controller/
2 lines
uiexample/
examples/
4 lines
14 lines
8 lines
6 lines
8 lines
infrastructure/
diff/
view/
18 lines
2 lines
4 lines
view/
control/
6 lines
2 lines
form/
control/
2 lines
2 lines
layout/
2 lines
page/
menu/
2 lines
phui/
2 lines
2 lines
2 lines
2 lines
14 lines
4 lines
2 lines
2 lines
2 lines
6 lines
4 lines
2 lines
2 lines
2 lines
6 lines
2 lines
2 lines
2 lines
2 lines
4 lines
calendar/
4 lines
2 lines
4 lines

Diff 36517

View Options

src/applications/almanac/controller/AlmanacController.php

View Options

src/applications/almanac/controller/AlmanacDeviceViewController.php

View Options

src/applications/almanac/controller/AlmanacServiceViewController.php

View Options

src/applications/auth/controller/config/PhabricatorAuthListController.php

View Options

src/applications/auth/data/PhabricatorAuthInviteAction.php

View Options

src/applications/auth/view/PhabricatorAuthSSHKeyTableView.php

View Options

src/applications/base/controller/PhabricatorController.php

View Options

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

View Options

src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php

View Options

src/applications/conduit/query/PhabricatorConduitLogSearchEngine.php

View Options

src/applications/conduit/settings/PhabricatorConduitTokensSettingsPanel.php

View Options

src/applications/config/controller/PhabricatorConfigCacheController.php

View Options

src/applications/config/controller/PhabricatorConfigDatabaseController.php

View Options

src/applications/config/controller/PhabricatorConfigWelcomeController.php

View Options

src/applications/config/module/PhabricatorConfigPHIDModule.php

View Options

src/applications/conpherence/controller/ConpherenceWidgetController.php

View Options

src/applications/conpherence/query/ConpherenceThreadSearchEngine.php

View Options

src/applications/conpherence/view/ConpherenceDurableColumnView.php

View Options

src/applications/conpherence/view/ConpherencePeopleWidgetView.php

View Options

src/applications/conpherence/view/ConpherenceThreadListView.php

View Options

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

View Options

src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php

View Options

src/applications/differential/constants/DifferentialRevisionStatus.php

View Options

src/applications/differential/view/DifferentialChangesetDetailView.php

View Options

src/applications/differential/view/DifferentialChangesetFileTreeSideNavBuilder.php

View Options

src/applications/differential/view/DifferentialRevisionListView.php

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

View Options

src/applications/diffusion/controller/DiffusionCommitController.php

View Options

src/applications/diffusion/controller/DiffusionRepositoryController.php

View Options

src/applications/diffusion/view/DiffusionBranchTableView.php

View Options

src/applications/diffusion/view/DiffusionView.php

View Options

src/applications/diviner/controller/DivinerBookController.php

View Options

src/applications/diviner/controller/DivinerMainController.php

View Options

src/applications/drydock/controller/DrydockBlueprintViewController.php

View Options

src/applications/drydock/controller/DrydockController.php

View Options

src/applications/drydock/controller/DrydockResourceViewController.php

View Options

src/applications/drydock/view/DrydockLogListView.php

View Options

src/applications/files/controller/PhabricatorFileComposeController.php

View Options

src/applications/files/controller/PhabricatorFileIconSetSelectController.php

View Options

src/applications/files/iconset/PhabricatorIconSet.php

View Options

src/applications/harbormaster/controller/HarbormasterBuildableViewController.php

View Options

src/applications/harbormaster/controller/HarbormasterPlanViewController.php

View Options

src/applications/herald/adapter/HeraldAdapter.php

View Options

src/applications/home/controller/PhabricatorHomeMainController.php

View Options

src/applications/legalpad/controller/LegalpadDocumentSignController.php

View Options

src/applications/legalpad/query/LegalpadDocumentSearchEngine.php

View Options

src/applications/legalpad/query/LegalpadDocumentSignatureSearchEngine.php

View Options

src/applications/macro/markup/PhabricatorIconRemarkupRule.php

View Options

src/applications/maniphest/constants/ManiphestTaskStatus.php

View Options

src/applications/metamta/applicationpanel/PhabricatorMetaMTAApplicationEmailPanel.php

View Options

src/applications/notification/controller/PhabricatorNotificationStatusController.php

View Options

src/applications/notification/query/PhabricatorNotificationSearchEngine.php

View Options

src/applications/people/controller/PhabricatorPeopleProfileManageController.php

View Options

src/applications/people/controller/PhabricatorPeopleProfileViewController.php

View Options

src/applications/phame/controller/PhameHomeController.php

View Options

src/applications/phame/controller/blog/PhameBlogViewController.php

View Options

src/applications/phame/controller/post/PhamePostViewController.php

View Options

src/applications/phame/view/PhameBlogListView.php

View Options

src/applications/phame/view/PhameDraftListView.php

View Options

src/applications/phame/view/PhameNextPostView.php

View Options

src/applications/phid/PhabricatorObjectHandle.php

View Options

src/applications/pholio/view/PholioMockImagesView.php

View Options

src/applications/pholio/view/PholioTransactionView.php

View Options

src/applications/phortune/controller/PhortuneAccountListController.php

View Options

src/applications/phortune/controller/PhortuneAccountViewController.php

View Options

src/applications/phortune/controller/PhortuneCartViewController.php

View Options

src/applications/phortune/controller/PhortuneMerchantViewController.php

View Options

src/applications/phortune/controller/PhortuneSubscriptionViewController.php

View Options

src/applications/phortune/view/PhortuneCreditCardForm.php

View Options

src/applications/phriction/controller/PhrictionDocumentController.php

View Options

src/applications/policy/storage/PhabricatorPolicy.php

View Options

src/applications/ponder/view/PonderAnswerView.php

View Options

src/applications/ponder/view/PonderFooterView.php

View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

View Options

src/applications/project/controller/PhabricatorProjectMilestonesController.php

View Options

src/applications/project/controller/PhabricatorProjectProfileController.php

View Options

src/applications/project/controller/PhabricatorProjectSubprojectsController.php

View Options

src/applications/project/query/PhabricatorProjectSearchEngine.php

View Options

src/applications/project/view/PhabricatorProjectListView.php

View Options

src/applications/project/view/PhabricatorProjectUserListView.php

View Options

src/applications/search/engine/PhabricatorProfilePanelEngine.php

View Options

src/applications/search/profilepanel/PhabricatorMotivatorProfilePanel.php

View Options

src/applications/settings/panel/PhabricatorDesktopNotificationsSettingsPanel.php

View Options

src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php

View Options

src/applications/settings/panel/PhabricatorHomePreferencesSettingsPanel.php

View Options

src/applications/settings/panel/PhabricatorMultiFactorSettingsPanel.php

View Options

src/applications/settings/panel/PhabricatorSSHKeysSettingsPanel.php

View Options

src/applications/settings/panel/PhabricatorSessionsSettingsPanel.php

View Options

src/applications/settings/panel/PhabricatorTokensSettingsPanel.php

View Options

src/applications/transactions/controller/PhabricatorApplicationTransactionValueController.php

View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

View Options

src/applications/transactions/view/PhabricatorApplicationEditHTTPParameterHelpView.php

View Options

src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php

View Options

src/applications/uiexample/examples/PHUIBoxExample.php

View Options

src/applications/uiexample/examples/PHUIButtonBarExample.php

View Options

src/applications/uiexample/examples/PHUIButtonExample.php

View Options

src/applications/uiexample/examples/PHUIFeedStoryExample.php

View Options

src/applications/uiexample/examples/PHUIIconExample.php

View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

View Options

src/infrastructure/diff/view/PHUIDiffRevealIconView.php

View Options

src/infrastructure/diff/view/PhabricatorInlineSummaryView.php

View Options

src/view/control/AphrontCursorPagerView.php

View Options

src/view/control/AphrontTokenizerTemplateView.php

View Options

src/view/form/control/AphrontFormDateControl.php

View Options

src/view/form/control/AphrontFormPolicyControl.php

View Options

src/view/layout/PhabricatorActionView.php

View Options

src/view/page/menu/PhabricatorMainMenuSearchView.php

View Options

src/view/phui/PHUIActionPanelView.php

View Options

src/view/phui/PHUIBadgeMiniView.php

View Options

src/view/phui/PHUIBadgeView.php

View Options

src/view/phui/PHUIBigInfoView.php

View Options

src/view/phui/PHUIButtonView.php

View Options

src/view/phui/PHUICrumbView.php

View Options

src/view/phui/PHUICrumbsView.php

View Options

src/view/phui/PHUIDocumentViewPro.php

View Options

src/view/phui/PHUIFeedStoryView.php

View Options

src/view/phui/PHUIHeaderView.php

View Options

src/view/phui/PHUIIconCircleView.php

View Options

src/view/phui/PHUIIconView.php

View Options

src/view/phui/PHUIListItemView.php

View Options

src/view/phui/PHUIObjectBoxView.php

View Options

src/view/phui/PHUIObjectItemView.php

View Options

src/view/phui/PHUIPinboardItemView.php

View Options

src/view/phui/PHUIPropertyListView.php

View Options

src/view/phui/PHUIStatusItemView.php

View Options

src/view/phui/PHUITagView.php

View Options

src/view/phui/PHUITimelineEventView.php

View Options

src/view/phui/calendar/PHUICalendarDayView.php

View Options

src/view/phui/calendar/PHUICalendarListView.php

View Options

src/view/phui/calendar/PHUICalendarMonthView.php

Phabricator · Built by Phacility