Remove redundant restructured text entry in default Paste highlighting options
ClosedPublic
Actions

Authored by epriestley on Jan 25 2016, 2:46 PM.

Details

Reviewers

chad

Maniphest Tasks

T10217: reStructuredText appears twice in the syntax highlighting dropdown

Commits

Restricted Diffusion Commit
rP1e69f06d7447: Remove redundant restructured text entry in default Paste highlighting options

Summary

Fixes T10217. This extra entry is just a mistake because of rst + rest both being valid suffixes. We don't need both entries.

Test Plan

Edited a paste, only saw one entry in dropdown for restructured text.

Diff Detail

Repository

rP Phabricator

Branch

2xrest

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10334
Build 12594: Run Core Tests
Build 12593: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36494.Jan 25 2016, 2:46 PM

epriestley retitled this revision from to Remove redundant restructured text entry in default Paste highlighting options.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10217: reStructuredText appears twice in the syntax highlighting dropdown.

chad accepted this revision.Jan 25 2016, 2:47 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 25 2016, 2:47 PM

Closed by commit rP1e69f06d7447: Remove redundant restructured text entry in default Paste highlighting options (authored by epriestley, committed by epriestley). · Explain WhyJan 25 2016, 2:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

option/

PhabricatorSyntaxHighlightingConfigOptions.php

3 lines

Diff 36494

View Options

src/applications/config/option/PhabricatorSyntaxHighlightingConfigOptions.php

Remove redundant restructured text entry in default Paste highlighting optionsClosedPublicActions