Fixes T10211. This transaction can either be setting or removing the "destroyed" flag, but we show "destroyed" in both cases.
Instead, if the transaction is clearing the flag, render "restored".
Details
Details
- Reviewers
chad - Maniphest Tasks
- T10211: wrong text, if you recreate a destroyed credential
- Commits
- Restricted Diffusion Commit
rP0b4ed94cc6ad: Fix text for Passphrase credential destruction transaction when restoring…
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- pphrase1
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 10287 Build 12523: Run Core Tests Build 12522: arc lint + arc unit
Event Timeline
Comment Actions
Actually, I kind of don't like this because I think the text implies that you revived the secret, too, which you did not (the secret is truly gone forever).
Maybe I'll just hide this transaction instead if I can't come up with some better text.
Comment Actions
- Adjust phrasing to talk about destroying, attaching and updating secrets. I think this is a little more clear.
