Fix an issue where the first click on the profile menu collapse link could be swallowed
ClosedPublic
Actions

Authored by epriestley on Jan 22 2016, 12:04 PM.

Details

Reviewers

Commits

Restricted Diffusion Commit
rP12a872678310: Fix an issue where the first click on the profile menu collapse link could be…

Summary

alterClass() is strict about true/false but we set 0/1 elsewhere.

Test Plan

Collapsed/expanded menu, reloaded expanded menu, clicked collapse, got immediate collapse.

Diff Detail

Repository

rP Phabricator

Branch

collapse1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10264
Build 12489: Run Core Tests
Build 12488: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36428.Jan 22 2016, 12:04 PM

epriestley retitled this revision from to Fix an issue where the first click on the profile menu collapse link could be swallowed.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

chad accepted this revision.Jan 22 2016, 2:51 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 22 2016, 2:51 PM

Closed by commit rP12a872678310: Fix an issue where the first click on the profile menu collapse link could be… (authored by epriestley, committed by epriestley). · Explain WhyJan 22 2016, 4:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

engine/

PhabricatorProfilePanelEngine.php

2 lines

Diff 36428

View Options

src/applications/search/engine/PhabricatorProfilePanelEngine.php

Fix an issue where the first click on the profile menu collapse link could be swallowedClosedPublicActions