Page MenuHomePhabricator
Differential D15087

Fix an issue where the first click on the profile menu collapse link could be swallowed
ClosedPublic
Actions

Authored by epriestley on Jan 22 2016, 12:04 PM.
Tags
None
Referenced Files
F13273987: D15087.diff
Fri, May 31, 3:09 AM
F13259886: D15087.diff
Sun, May 26, 11:13 PM
F13242707: D15087.diff
Thu, May 23, 3:02 AM
F13229601: D15087.id.diff
Mon, May 20, 5:47 PM
F13216699: D15087.diff
Sat, May 18, 1:54 AM
F13206016: D15087.id36437.diff
Wed, May 15, 4:38 AM
F13200516: D15087.diff
Tue, May 14, 1:02 AM
F13200288: D15087.diff
Mon, May 13, 10:52 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rP12a872678310: Fix an issue where the first click on the profile menu collapse link could be…
Summary

alterClass() is strict about true/false but we set 0/1 elsewhere.

Test Plan

Collapsed/expanded menu, reloaded expanded menu, clicked collapse, got immediate collapse.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36428.Jan 22 2016, 12:04 PM
epriestley retitled this revision from to Fix an issue where the first click on the profile menu collapse link could be swallowed.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Jan 22 2016, 2:51 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 22 2016, 2:51 PM
Closed by commit rP12a872678310: Fix an issue where the first click on the profile menu collapse link could be… (authored by epriestley, committed by epriestley). · Explain WhyJan 22 2016, 4:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
search/
engine/
2 lines

Diff 36437

View Options

src/applications/search/engine/PhabricatorProfilePanelEngine.php

Loading...
Phabricator · Built by Phacility