storage adjust` emit detailed messages if the user has no access to databases
ClosedPublic
Actions

Authored by epriestley on Jan 21 2016, 9:04 PM.

Details

Reviewers

chad

Maniphest Tasks

T10195: Failed to upgrade phabricator(phabricator_xhpast Missing)

Commits

Restricted Diffusion Commit
rPd37153f00304: Make `bin/storage upgrade` and `bin/storage adjust` emit detailed messages if…

Summary

Ref T10195. Distinguish between "database does not exist" and "database exists, you just don't have permission to access it".

We can't easily get this information out of INFORMATION_SCHEMA but can just SHOW TABLES IN ... every database that looks like it's missing and then look at the error code.

Test Plan

Created a user limited with limited access.
Ran bin/storage adjust.
Got hopefully more helpful messages about access problems, instead of "Missing" errors.

Diff Detail

Repository

rP Phabricator

Branch

access1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10243
Build 12456: Run Core Tests
Build 12455: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36407.Jan 21 2016, 9:04 PM

epriestley retitled this revision from to Make `bin/storage upgrade` and `bin/storage adjust` emit detailed messages if the user has no access to databases.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10195: Failed to upgrade phabricator(phabricator_xhpast Missing).

chad accepted this revision.Jan 21 2016, 9:05 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 21 2016, 9:05 PM

Closed by commit rPd37153f00304: Make `bin/storage upgrade` and `bin/storage adjust` emit detailed messages if… (authored by epriestley, committed by epriestley). · Explain WhyJan 21 2016, 9:06 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10195: Failed to upgrade phabricator(phabricator_xhpast Missing).Jan 21 2016, 9:07 PM

epriestley mentioned this in T8752: PhabricatorAuthProviderOAuthGoogle and PhabricatorAuthProviderPassword both show Provider Implementation Missing! .Jan 21 2016, 9:18 PM