Paths

Table of Contentst

Differential D15048

When removing project slugs, try to remove raw slugs too so we can remove old/invalid slugs
ClosedPublic
Actions

Authored by epriestley on Jan 18 2016, 5:10 PM.

Details

Reviewers

chad

Maniphest Tasks

T10168: Provide a clearer pathway forward for old projects with invalid hashtags

Commits

Restricted Diffusion Commit
rPcadd3f105620: When removing project slugs, try to remove raw slugs too so we can remove…

Summary

Ref T10168. When we try to remove an additional hashtag, we remove the normalized version.

Instead, remove both the literal and normalized versions. This allows us to remove old/invalid slugs.

Test Plan

Removed garbage slugs like [,*,].

Diff Detail

Repository

rP Phabricator

Branch

tag4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10177
Build 12355: Run Core Tests
Build 12354: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36342.Jan 18 2016, 5:10 PM

epriestley retitled this revision from to When removing project slugs, try to remove raw slugs too so we can remove old/invalid slugs.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10168: Provide a clearer pathway forward for old projects with invalid hashtags.

chad accepted this revision.Jan 18 2016, 5:14 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 18 2016, 5:14 PM

Closed by commit rPcadd3f105620: When removing project slugs, try to remove raw slugs too so we can remove… (authored by epriestley, committed by epriestley). · Explain WhyJan 18 2016, 5:14 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10168: Provide a clearer pathway forward for old projects with invalid hashtags.Jan 18 2016, 5:15 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

editor/

PhabricatorProjectTransactionEditor.php

9 lines

Diff 36342

View Options

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

When removing project slugs, try to remove raw slugs too so we can remove old/invalid slugsClosedPublicActions