Ref T10054. Without max-width, Safari can make this too large with a long project name (maybe because of table-cell?).
Details
Details
- Reviewers
chad - Maniphest Tasks
- T10054: Define product direction for Project/Profile UIs
- Commits
- Restricted Diffusion Commit
rP5d0222d532c1: Fix an issue where the profile menu could become enormous
Saw normal-width menu instead of huge menu on very long project.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- tag2
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 10169 Build 12345: Run Core Tests Build 12344: arc lint + arc unit
Event Timeline
Comment Actions
Does the text not ellipsis?
| webroot/rsrc/css/phui/phui-profile-menu.css | ||
|---|---|---|
| 40 | if this container has a width, it should do ... i think? | |
Comment Actions
That does also fix it (at least, if I add box-sizing: border-box; or do the math myself) I think it's better to not require all the sub-elements to have explicit widths if we can get away with it -- if nothing else, I imagine that'll make collapsing a bit messier.
Comment Actions
The text does ellipsis.
...if forced to by max-width, that is.
I think this is just a weird interaction between width: ... and display: table-cell because removing display: table-cell (without max-width) gives us the correct width (it just creates other display-related issues):
