Page MenuHomePhabricator
Differential D15045

Fix smushing of multiple values in Projects "Additional Hashtags" field
ClosedPublic
Actions

Authored by epriestley on Jan 18 2016, 3:29 PM.
Tags
None
Referenced Files
F19019642: D15045.diff
Sun, Nov 23, 3:37 PM
F19002496: D15045.diff
Fri, Nov 21, 6:18 AM
F18934607: D15045.diff
Nov 10 2025, 4:24 PM
F18907028: D15045.id36333.diff
Nov 8 2025, 9:43 PM
F18877442: D15045.diff
Nov 6 2025, 8:37 AM
F18838551: D15045.diff
Oct 27 2025, 11:26 AM
F18819862: D15045.id36337.diff
Oct 22 2025, 10:23 AM
F18818984: D15045.id36337.diff
Oct 22 2025, 3:37 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10168: Provide a clearer pathway forward for old projects with invalid hashtags
Commits
Restricted Diffusion Commit
rP9ae48d4026fc: Fix smushing of multiple values in Projects "Additional Hashtags" field
Summary

Ref T10168. When we render this control, we currently don't put commas into the value correctly if there are multiple alternative hashtags.

Test Plan

Edited a project with multiple alternate hashtags. Before change: they all got smushed together. After change: properly comma-separated.

Diff Detail

Repository
rP Phabricator
Branch
tag1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10168
Build 12343: Run Core Tests
Build 12342: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36333.Jan 18 2016, 3:29 PM
epriestley retitled this revision from to Fix smushing of multiple values in Projects "Additional Hashtags" field.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10168: Provide a clearer pathway forward for old projects with invalid hashtags.
chad accepted this revision.Jan 18 2016, 3:50 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 18 2016, 3:50 PM
Closed by commit rP9ae48d4026fc: Fix smushing of multiple values in Projects "Additional Hashtags" field (authored by epriestley, committed by epriestley). · Explain WhyJan 18 2016, 4:34 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10168: Provide a clearer pathway forward for old projects with invalid hashtags.Jan 18 2016, 5:15 PM

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
editfield/
5 lines

Diff 36333

View Options

src/applications/transactions/editfield/PhabricatorStringListEditField.php

Loading...
Phabricator · Built by Phacility