Page MenuHomePhabricator

Improve autocomplete behavior in lists and with noncompleting results
ClosedPublic

Authored by epriestley on Jan 16 2016, 11:04 PM.
Tags
None
Referenced Files
F13158714: D15040.diff
Sun, May 5, 9:00 PM
Unknown Object (File)
Fri, May 3, 9:03 AM
Unknown Object (File)
Thu, Apr 25, 2:43 AM
Unknown Object (File)
Sun, Apr 21, 6:17 AM
Unknown Object (File)
Fri, Apr 19, 4:07 PM
Unknown Object (File)
Thu, Apr 11, 9:57 AM
Unknown Object (File)
Mar 30 2024, 4:52 PM
Unknown Object (File)
Mar 24 2024, 10:27 AM
Subscribers
None

Details

Summary

Ref T10163. Currently, we don't activate on indented lines, but were too aggressive about this, and would not activate on lines like - Hey, @user..., where we should.

Instead, don't activate on indented lines if there's only an indent (i.e., # probably means enumerated list).

Also, if results don't have autocompletes (rare but possible with projects missing slugs), improve behavior.

Test Plan
  • Typed #a, got no autocomplete.
  • Missing slug thing is a pain to test locallly, #1 z z z z reproduces in production. I'll just verify it there.

Diff Detail

Repository
rP Phabricator
Branch
auto11
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10160
Build 12330: Run Core Tests
Build 12329: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Improve autocomplete behavior in lists and with noncompleting results.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 16 2016, 11:17 PM
This revision was automatically updated to reflect the committed changes.