Differential D15034

PHUIIconCircleView
ClosedPublic
Actions

Authored by chad on Jan 16 2016, 5:39 AM.

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP2144d877ee30: PHUIIconCircleView

Summary

Icon in a circle. Base class, not much in the way of color choices.

Test Plan

UIExamples, Chrome.

Diff Detail

Repository

rP Phabricator

Branch

circle (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10149
Build 12313: Run Core Tests
Build 12312: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 36314.Jan 16 2016, 5:39 AM

chad retitled this revision from to PHUIIconCircleView.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptJan 16 2016, 5:39 AM

chad edited the test plan for this revision. (Show Details)Jan 16 2016, 5:39 AM

epriestley accepted this revision.Jan 18 2016, 3:08 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 18 2016, 3:08 PM

Closed by commit rP2144d877ee30: PHUIIconCircleView (authored by chad, committed by chad). · Explain WhyJan 18 2016, 5:03 PM

This revision was automatically updated to reflect the committed changes.

I'm not immediately having much luck getting this integrated cleanly into a menu context, so I'm going to leave it for the moment. If I swap the icon for a circle-icon it creates a lot of rule collisions with the existing menu code that throw off spacing, sizing, highlighting, etc:

Screen Shot 2016-01-19 at 10.40.35 AM.png (144×302 px, 11 KB)

avivey awarded a token.Jan 19 2016, 6:52 PM

You're welcome to leave the normal icons and I can back. Also, I'd place both links on one line if we're going to do the slightly wider "collapsed" sidenav with names.