Page MenuHomePhabricator

Fix blur and sort behavior for autocomplete
ClosedPublic

Authored by epriestley on Jan 15 2016, 5:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 21, 6:17 AM
Unknown Object (File)
Fri, Apr 19, 4:06 PM
Unknown Object (File)
Apr 3 2024, 8:57 AM
Unknown Object (File)
Mar 31 2024, 2:07 AM
Unknown Object (File)
Feb 21 2024, 12:43 PM
Unknown Object (File)
Feb 14 2024, 2:41 PM
Unknown Object (File)
Feb 11 2024, 7:24 PM
Unknown Object (File)
Feb 11 2024, 7:23 PM
Subscribers
None

Details

Summary

Ref T10163.

  • If you click a result, we get a blur before your click hits, and deactivate before the click can work. Instead, wait before responding to blur.
  • Use the standard sort handler which puts unixnames over human names. Also use the standard filter which deals with disabled users not matching unless they're the only match.
Test Plan
  • Clicked a result, got a replacement.
  • Named myself "dog dog", typed "@dog", user "@dog" was now first match despite me being "@admin".
  • Used normal typeaheads to make sure I didn't break sort handler.

Diff Detail

Repository
rP Phabricator
Branch
auto1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10143
Build 12304: Run Core Tests
Build 12303: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix blur and sort behavior for autocomplete.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 15 2016, 5:33 PM
This revision was automatically updated to reflect the committed changes.