Differential D15025

fix bug
ClosedPublic
Actions

Authored by epriestley on Jan 14 2016, 10:41 PM.

Details

Reviewers

chad

Commits

rPHUf10d2a532535: (stable) Promote 2016 Week 3
rPHUc3fd3a8bb2c3: fix bug

Summary

big bug

Test Plan

!!!!!

Diff Detail

Repository

rPHU libphutil

Branch

highlight1

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	src/markup/engine/__tests__/remarkup/highlight.txt:6	TXT3	Line Too Long
Warning	src/markup/engine/__tests__/remarkup/highlight.txt:9	TXT3	Line Too Long

Unit

Tests Passed

Build Status

Buildable 10113
Build 12260: Run Core Tests
Build 12259: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36281.Jan 14 2016, 10:41 PM

epriestley retitled this revision from to fix bug.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

chad accepted this revision.Jan 14 2016, 10:45 PM

chad edited edge metadata.

chad added inline comments.

src/markup/engine/remarkup/markuprule/PhutilRemarkupHighlightRule.php
27	:(

This revision is now accepted and ready to land.Jan 14 2016, 10:45 PM

Closed by commit rPHUc3fd3a8bb2c3: fix bug (authored by epriestley, committed by epriestley). · Explain WhyJan 14 2016, 10:46 PM

This revision was automatically updated to reflect the committed changes.

what is that face

Really good commit message! Thank you for that! Learned a lot again with your help...

Revision Contents
Changeset List

Path

Size

src/

markup/

engine/

__tests__/

remarkup/

highlight.txt

6 lines

remarkup/

markuprule/

PhutilRemarkupHighlightRule.php

7 lines

Diff 36281

View Options

src/markup/engine/tests/remarkup/highlight.txt

View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupHighlightRule.php

fix bugClosedPublicActions