Page MenuHomePhabricator
Differential D15009

Change wording of "Show Entire File" to "Show All Context"
ClosedPublic
Actions

Authored by epriestley on Jan 13 2016, 2:21 PM.
Tags
None
Referenced Files
F14035973: D15009.diff
Sun, Nov 10, 8:08 AM
F14001278: D15009.id36261.diff
Fri, Oct 25, 5:58 AM
F13994006: D15009.diff
Wed, Oct 23, 3:06 AM
F13993785: D15009.id36253.diff
Wed, Oct 23, 1:24 AM
F13972550: D15009.id.diff
Thu, Oct 17, 7:41 PM
Unknown Object (File)
Oct 11 2024, 8:11 AM
Unknown Object (File)
Oct 6 2024, 6:17 AM
Unknown Object (File)
Oct 2 2024, 3:17 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10139: Clarify wording used in the Differential diff "View Options" dropdown
Commits
Restricted Diffusion Commit
rPfdd5500fec64: Change wording of "Show Entire File" to "Show All Context"
Summary

Fixes T10139. This clarification seems reasonable to me.

Test Plan
  • Viewed a revision with context.
  • Clicked "Show All Context".
  • Saw "All Context Shown".

Screen Shot 2016-01-13 at 6.21.26 AM.png (315×331 px, 28 KB)

Screen Shot 2016-01-13 at 6.21.22 AM.png (358×338 px, 29 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36253.Jan 13 2016, 2:21 PM
epriestley retitled this revision from to Change wording of "Show Entire File" to "Show All Context".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10139: Clarify wording used in the Differential diff "View Options" dropdown.
chad accepted this revision.Jan 13 2016, 6:03 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 13 2016, 6:03 PM
Closed by commit rPfdd5500fec64: Change wording of "Show Entire File" to "Show All Context" (authored by epriestley, committed by epriestley). · Explain WhyJan 13 2016, 7:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
54 lines
src/
applications/
differential/
view/
4 lines
webroot/
rsrc/
js/
application/
differential/
4 lines
4 lines

Diff 36261

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/view/DifferentialChangesetListView.php

Loading...
View Options

webroot/rsrc/js/application/differential/ChangesetViewManager.js

Loading...
View Options

webroot/rsrc/js/application/differential/behavior-dropdown-menus.js

Loading...
Phabricator · Built by Phacility