Page MenuHomePhabricator
Create Task
Maniphest T10139

Clarify wording used in the Differential diff "View Options" dropdown
Closed, ResolvedPublic
Actions

Description

In the file section of a diff, the dropdown "View Options" currently uses the text "Show Entire File" and "Entire File Shown".

Since you can't actually view the entire file unless you have provided the entire context, this is incorrect.

pasted_file (389×1 px, 89 KB)

Considering that automatically providing context isn't in the works, I propose that the wording be changed.

  • Show Entire File => Show All Context
  • Entire File Shown => All Context Shown

EDIT: "Show Entire Diff" would also be reasonable, but less clear about what is getting expanded

Revisions and Commits

rP Phabricator
D15009rPfdd5500fec64 Change wording of "Show Entire File" to "Show All Context"

Event Timeline

• tesla renamed this task from Clarify wording used in the Revision diff "View Options" dropdown to Clarify wording used in the Differential diff "View Options" dropdown.Jan 13 2016, 6:23 AM
• tesla created this task.
• tesla updated the task description. (Show Details)
epriestley added a revision: D15009: Change wording of "Show Entire File" to "Show All Context".Jan 13 2016, 2:21 PM
epriestley claimed this task.Jan 13 2016, 2:21 PM
epriestley triaged this task as Low priority.
epriestley added a comment.Jan 13 2016, 2:24 PM

Yeah, I agree your suggestions are more clear (and "Entire Diff" would be a little murkier).

There's still a "Show All Context" button in the "Table of Contents" table which means "Show All Context (of all files)" but I think that's mostly clear-ish from context and can't come up with a more clear version that isn't much longer. I think that option may move somewhere else eventually so I'm just going to leave it as-is for now.

epriestley closed this task as Resolved by committing rPfdd5500fec64: Change wording of "Show Entire File" to "Show All Context".Jan 13 2016, 7:09 PM
epriestley added a commit: rPfdd5500fec64: Change wording of "Show Entire File" to "Show All Context".
Phabricator · Built by Phacility